From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 11 Nov 2019 09:18:03 -0500 Subject: [U-Boot] [PATCH v2 05/41] common: Move random-number functions into their own header In-Reply-To: <20191108125120.v2.5.I7aa3d4f52a2b16462b1c11eb90dcca7e2a1e52a5@changeid> References: <20191108195348.110648-1-sjg@chromium.org> <20191108125120.v2.5.I7aa3d4f52a2b16462b1c11eb90dcca7e2a1e52a5@changeid> Message-ID: <20191111141803.GA19317@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Nov 08, 2019 at 12:53:12PM -0700, Simon Glass wrote: > Create a new rand.h header file and move functions into it, to reduce > the size of common.h > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > include/common.h | 6 ------ > include/net.h | 1 + > include/rand.h | 40 ++++++++++++++++++++++++++++++++++++++++ > lib/rand.c | 1 + > net/link_local.c | 1 + > 5 files changed, 43 insertions(+), 6 deletions(-) > create mode 100644 include/rand.h > > diff --git a/include/common.h b/include/common.h > index 52bcc2e591..b09c7aeddd 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -325,12 +325,6 @@ char * strmhz(char *buf, unsigned long hz); > /* lib/crc32.c */ > #include > > -/* lib/rand.c */ > -#define RAND_MAX -1U > -void srand(unsigned int seed); > -unsigned int rand(void); > -unsigned int rand_r(unsigned int *seedp); > - > /* > * STDIO based functions (can always be used) > */ > diff --git a/include/net.h b/include/net.h > index 75a16e4c8f..d8d187d8af 100644 > --- a/include/net.h > +++ b/include/net.h > @@ -16,6 +16,7 @@ > #include /* for nton* / ntoh* stuff */ > #include > #include > +#include > > #define DEBUG_LL_STATE 0 /* Link local state machine changes */ > #define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */ OK, but common.h includes net.h, and I don't see this addressed further in the series. So this is a step in the right direction, but does it get messy to not include it? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: