public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/1] cmd: adding malloc, math, and strcmp commands to u-boot
Date: Tue, 19 Nov 2019 15:37:33 -0500	[thread overview]
Message-ID: <20191119203733.GI19317@bill-the-cat> (raw)
In-Reply-To: <20191119002630.15088-1-vladimir.olovyannikov@broadcom.com>

On Mon, Nov 18, 2019 at 04:26:30PM -0800, Vladimir Olovyannikov wrote:

> cmd: adding malloc, math, and strcmp u-boot commands.
> - malloc  supports allocation of heap memory and free allocated memory
>           via u-boot command line.

Can you expand on how this is used in a script?  I'm not sure I see that
exactly.  Also:

> +config CMD_MALLOC
> +	bool "malloc"
> +	default y
> +	help
> +	  Supports allocation of heap memory and free allocated memory commands.
> +	  These commands are used by u-boot scripts.
> +
> +config CMD_MATH
> +	bool "math"
> +	default y
> +	help
> +	  Provides math commands such as add, sub, mul, div, shift,
> +	  convert decimal to hex functionalities to be available in the script.

First, why do we need this, rather than using setexpr ?

> +
>  config CMD_SOURCE
>  	bool "source"
>  	default y
> @@ -1301,6 +1315,13 @@ config CMD_SETEXPR
>  	  Also supports loading the value at a memory location into a variable.
>  	  If CONFIG_REGEX is enabled, setexpr also supports a gsub function.
>  
> +config CMD_STRCMP
> +	bool "strcmp"
> +	default y
> +	help
> +	  Provides string compare command feature to u-boot scripts.

Second, new commands must not default to y, but they should be enabled
on sandbox and new test.py tests added for them.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191119/a7f5af39/attachment.sig>

  parent reply	other threads:[~2019-11-19 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  0:26 [U-Boot] [PATCH v1 1/1] cmd: adding malloc, math, and strcmp commands to u-boot Vladimir Olovyannikov
2019-11-19  1:21 ` Simon Glass
2019-11-19 20:02   ` Vladimir Olovyannikov
2019-11-19 20:37 ` Tom Rini [this message]
2019-11-20 22:50   ` Vladimir Olovyannikov
2019-11-20 23:26     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191119203733.GI19317@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox