public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mtd: rawnand: denali: Do not reset the block on SoCFPGA
Date: Wed, 20 Nov 2019 22:37:22 +0100	[thread overview]
Message-ID: <20191120213722.19170-3-marex@denx.de> (raw)
In-Reply-To: <20191120213722.19170-1-marex@denx.de>

Legacy kernel versions for SoCFPGA may not implement proper reset
handling. Apply the same approach as SoCFPGA reset driver, check
environment variable "socfpga_legacy_reset_compat", and if it is
set, do not reset the IP before booting Linux. This way, even the
older kernel versions can be booted by up to date U-Boot.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
---
 drivers/mtd/nand/raw/denali_dt.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/mtd/nand/raw/denali_dt.c b/drivers/mtd/nand/raw/denali_dt.c
index 2c9e249ab6..d35f2a3543 100644
--- a/drivers/mtd/nand/raw/denali_dt.c
+++ b/drivers/mtd/nand/raw/denali_dt.c
@@ -148,6 +148,18 @@ static int denali_dt_remove(struct udevice *dev)
 {
 	struct denali_nand_info *denali = dev_get_priv(dev);
 
+#if CONFIG_IS_ENABLED(ARCH_SOCFPGA)
+	/*
+	 * Legacy kernel versions do not implement proper reset handling on
+	 * SoCFPGA. To let those older kernel versions work, reuse the same
+	 * approach as the SoCFPGA reset driver does -- check environment
+	 * variable socfpga_legacy_reset_compat and avoid resetting the IP
+	 * before booting the kernel if it is set to 1.
+	 */
+	if (env_get_ulong("socfpga_legacy_reset_compat", 10, 0))
+		return 0;
+#endif
+
 	return reset_release_bulk(&denali->resets);
 }
 
-- 
2.24.0.432.g9d3f5f5b63

  parent reply	other threads:[~2019-11-20 21:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 21:37 [U-Boot] [PATCH 1/3] mtd: rawnand: denali-spl: Add missing hardware init Marek Vasut
2019-11-20 21:37 ` [U-Boot] [PATCH 2/3] mtd: rawnand: denali: Allow operation without clock driver Marek Vasut
2019-11-26  3:40   ` Masahiro Yamada
2019-11-26  8:13     ` Marek Vasut
2019-11-20 21:37 ` Marek Vasut [this message]
2019-11-26  2:47   ` [U-Boot] [PATCH 3/3] mtd: rawnand: denali: Do not reset the block on SoCFPGA Masahiro Yamada
2019-11-26  8:17     ` Marek Vasut
2019-11-26  8:46       ` Masahiro Yamada
2019-11-26  9:01         ` Marek Vasut
2019-11-26  9:07           ` Masahiro Yamada
2019-11-26  9:10             ` Marek Vasut
2019-11-26  9:17               ` Masahiro Yamada
2019-11-26  9:44                 ` Marek Vasut
2019-11-26  8:48       ` Simon Goldschmidt
2019-11-26  2:34 ` [U-Boot] [PATCH 1/3] mtd: rawnand: denali-spl: Add missing hardware init Masahiro Yamada
2019-11-26  8:15   ` Marek Vasut
2019-11-26  9:24     ` Masahiro Yamada
2019-11-26  9:43       ` Marek Vasut
2019-11-27 10:20     ` Masahiro Yamada
2019-11-27 10:47       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120213722.19170-3-marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox