From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] sunxi: board: Use eth_env_set_enetaddr_by_index()
Date: Tue, 26 Nov 2019 09:15:59 +0100 [thread overview]
Message-ID: <20191126081602.2264519-2-a.heider@gmail.com> (raw)
In-Reply-To: <20191126081602.2264519-1-a.heider@gmail.com>
That helper takes care of assembling the correct name and doesn't allow
overwriting existing env vars, so drop the checks here.
Signed-off-by: Andre Heider <a.heider@gmail.com>
---
board/sunxi/board.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/board/sunxi/board.c b/board/sunxi/board.c
index e3b2d13892..bb35d6b66e 100644
--- a/board/sunxi/board.c
+++ b/board/sunxi/board.c
@@ -807,14 +807,6 @@ static void setup_environment(const void *fdt)
if (!fdt_get_alias(fdt, ethaddr))
continue;
- if (i == 0)
- strcpy(ethaddr, "ethaddr");
- else
- sprintf(ethaddr, "eth%daddr", i);
-
- if (env_get(ethaddr))
- continue;
-
/* Non OUI / registered MAC address */
mac_addr[0] = (i << 4) | 0x02;
mac_addr[1] = (sid[0] >> 0) & 0xff;
@@ -823,7 +815,7 @@ static void setup_environment(const void *fdt)
mac_addr[4] = (sid[3] >> 8) & 0xff;
mac_addr[5] = (sid[3] >> 0) & 0xff;
- eth_env_set_enetaddr(ethaddr, mac_addr);
+ eth_env_set_enetaddr_by_index("eth", i, mac_addr);
}
if (!env_get("serial#")) {
--
2.24.0
next prev parent reply other threads:[~2019-11-26 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 8:15 [U-Boot] [PATCH v2 0/4] arm64: dts: sun50i: Add support for Orange Pi 3 Andre Heider
2019-11-26 8:15 ` Andre Heider [this message]
2019-11-26 10:22 ` [U-Boot] [PATCH v2 1/4] sunxi: board: Use eth_env_set_enetaddr_by_index() Ondřej Jirman
2019-11-26 12:12 ` Andre Heider
2019-11-26 8:16 ` [U-Boot] [PATCH v2 2/4] arm: sunxi: add a config option to fixup a Bluetooth address Andre Heider
2019-11-26 10:46 ` Ondřej Jirman
2019-11-26 10:50 ` Ondřej Jirman
2019-11-26 12:15 ` Andre Heider
2019-11-26 12:40 ` Ondřej Jirman
2019-11-26 14:08 ` Andre Heider
2019-11-26 8:16 ` [U-Boot] [PATCH v2 3/4] arm64: dts: sync Allwinner H6 files Andre Heider
2019-11-26 8:16 ` [U-Boot] [PATCH v2 4/4] arm64: dts: sun50i: Add support for Orange Pi 3 Andre Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126081602.2264519-2-a.heider@gmail.com \
--to=a.heider@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox