public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 03/16] efi_loader: add signature verification functions
Date: Wed, 27 Nov 2019 10:29:23 +0900	[thread overview]
Message-ID: <20191127012922.GJ22427@linaro.org> (raw)
In-Reply-To: <20191126115529.GA20407@apalos.home>

On Tue, Nov 26, 2019 at 01:55:29PM +0200, Ilias Apalodimas wrote:
> [...]
> > +	/* verify signature */
> > +		/* against digest */
> > +		c = 0x31;
> > +		regtmp[0].data = &c;
> > +		regtmp[0].size = 1;
> 
> Is there a reason for '1' instea of sizeof(c)?

Yes, it explicitly says that we want to add *exact one byte* for
hash calculation here.

Thanks,
-Takahiro Akashi

> > +		regtmp[1].data = ps_info->authattrs;
> > +		regtmp[1].size = ps_info->authattrs_len;
> > +
> > +
> > +out:
> 
> Thanks
> /Ilias

  reply	other threads:[~2019-11-27  1:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  0:51 [U-Boot] [PATCH v2 00/16] efi_loader: add secure boot support AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 01/16] include: pe.h: add signature-related definitions AKASHI Takahiro
2019-11-26  2:55   ` Heinrich Schuchardt
2019-11-26  0:51 ` [U-Boot] [PATCH v2 02/16] efi_loader: add CONFIG_EFI_SECURE_BOOT config option AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 03/16] efi_loader: add signature verification functions AKASHI Takahiro
2019-11-26 11:55   ` Ilias Apalodimas
2019-11-27  1:29     ` AKASHI Takahiro [this message]
2019-11-26  0:51 ` [U-Boot] [PATCH v2 04/16] efi_loader: add signature database parser AKASHI Takahiro
2019-11-28 14:21   ` Ilias Apalodimas
2019-11-28 14:49     ` Ilias Apalodimas
2019-12-02  0:49       ` AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 05/16] efi_loader: variable: support variable authentication AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 06/16] efi_loader: variable: add secure boot state transition AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 07/16] efi_loader: variable: add VendorKeys variable AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 08/16] efi_loader: image_loader: support image authentication AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 09/16] efi_loader: set up secure boot AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 10/16] cmd: env: use appropriate guid for authenticated UEFI variable AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 11/16] cmd: env: add "-at" option to "env set -e" command AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 12/16] efi_loader, pytest: set up secure boot environment AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 13/16] efi_loader, pytest: add UEFI secure boot tests (authenticated variables) AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 14/16] efi_loader, pytest: add UEFI secure boot tests (image) AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 15/16] sandbox: add extra configurations for UEFI and related tests AKASHI Takahiro
2019-11-26  0:51 ` [U-Boot] [PATCH v2 16/16] travis: add packages for UEFI secure boot test AKASHI Takahiro
2019-12-05 15:44   ` Tom Rini
2019-11-26  1:23 ` [U-Boot] [PATCH v2 00/16] efi_loader: add secure boot support AKASHI Takahiro
2019-11-28 13:48 ` Ilias Apalodimas
2019-12-04  2:43 ` AKASHI Takahiro
2019-12-04  7:31   ` Heinrich Schuchardt
2019-12-04  8:28     ` AKASHI Takahiro
2019-12-04 23:58       ` Tom Rini
2019-12-11  0:41       ` AKASHI Takahiro
2019-12-11  1:54         ` Tom Rini
2019-12-11  2:10           ` AKASHI Takahiro
2019-12-11 20:28             ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127012922.GJ22427@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox