From mboxrd@z Thu Jan  1 00:00:00 1970
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Wed, 27 Nov 2019 10:29:23 +0900
Subject: [U-Boot] [PATCH v2 03/16] efi_loader: add signature
	verification functions
In-Reply-To: <20191126115529.GA20407@apalos.home>
References: <20191126005120.31156-1-takahiro.akashi@linaro.org>
 <20191126005120.31156-4-takahiro.akashi@linaro.org>
 <20191126115529.GA20407@apalos.home>
Message-ID: <20191127012922.GJ22427@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Nov 26, 2019 at 01:55:29PM +0200, Ilias Apalodimas wrote:
> [...]
> > +	/* verify signature */
> > +		/* against digest */
> > +		c = 0x31;
> > +		regtmp[0].data = &c;
> > +		regtmp[0].size = 1;
> 
> Is there a reason for '1' instea of sizeof(c)?

Yes, it explicitly says that we want to add *exact one byte* for
hash calculation here.

Thanks,
-Takahiro Akashi

> > +		regtmp[1].data = ps_info->authattrs;
> > +		regtmp[1].size = ps_info->authattrs_len;
> > +
> > +
> > +out:
> 
> Thanks
> /Ilias