From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 27 Nov 2019 16:09:38 +0100 Subject: [U-Boot] [PATCH v1 3/4] dfu: Add optional timeout parameter In-Reply-To: <20191127143842.GM32742@smile.fi.intel.com> References: <20191113174344.33736-1-andriy.shevchenko@linux.intel.com> <20191113174344.33736-3-andriy.shevchenko@linux.intel.com> <20191127115615.43217f5c@jawa> <20191127143842.GM32742@smile.fi.intel.com> Message-ID: <20191127160938.6e8475fc@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andy, > On Wed, Nov 27, 2019 at 11:56:15AM +0100, Lukasz Majewski wrote: > > > Thank you for your work on enhancing DFU. The patch series is > > generally Ok. > > > > Please find some minor comments/requests below. > > Thank you for review, my answers below. > > > > +#ifdef CONFIG_DFU_TIMEOUT > > > + dfu_set_timeout(value * 1000); > > > +#endif > > (1) > > > > +#ifdef CONFIG_DFU_TIMEOUT > > > +void dfu_set_timeout(unsigned long timeout) > > > +{ > > > + dfu_timeout = timeout; > > > +} > > > > I do guess that dfu_set_timeout() is not yet used in this patch > > series? > > I think you missed (1) by some reason. Right. Thanks for pointing this out. > > > Please add some description and example of this new option / > > feature to ./doc/README.dfu file. > > Will do for v2. > Thanks, appreciated. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: