From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] rockchip: px30: Add support for using UART3 as debug UART
Date: Thu, 28 Nov 2019 10:57:48 +0100 [thread overview]
Message-ID: <20191128095748.GA257289@aptenodytes> (raw)
In-Reply-To: <127f402c-4436-a38b-d368-fea140235b0a@theobroma-systems.com>
Hi Heiko,
On Thu 28 Nov 19, 10:44, Heiko Stuebner wrote:
> On 27.11.19 11:12, Paul Kocialkowski wrote:
> > Some generic PX30 SoMs found in the wild use UART3 as their debug output
> > instead of UART2 (used for MMC) and UART5.
> >
> > Make it possible to use UART3 as early debug output, with the associated
> > clock and pinmux configuration. Two sets of output pins are supported (M0/M1)
> > so a Kconfig option to select between the two is introduced like it's done
> > for UART2.
> >
> > Future users should also note that the pinmux default in the dts is to use
> > the M1 pins while the Kconfig option takes M0 as a default.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>
> Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> with one small question below
>
> > diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig
> > index 109a37be15ad..167517bbd63f 100644
> > --- a/arch/arm/mach-rockchip/px30/Kconfig
> > +++ b/arch/arm/mach-rockchip/px30/Kconfig
> > @@ -36,6 +36,15 @@ config DEBUG_UART2_CHANNEL
> > For using the UART for early debugging the route to use needs
> > to be declared (0 or 1).
> > +config DEBUG_UART3_CHANNEL
> > + int "Mux channel to use for debug UART3"
> > + depends on DEBUG_UART_BOARD_INIT
> > + default 0
> > + help
> > + UART3 can use two different set of pins to route the output.
> > + For using the UART for early debugging the route to use needs
> > + to be declared (0 or 1).
> > +
> > source "board/rockchip/evb_px30/Kconfig"
>
> Would it make sense to rename DEBUG_UART3_CHANNEL to just
> DEBUG_UART_CHANNEL and reuse it, so that we don't collect similar
> options for each uart?
Yes I like that better too. Will craft a v2 with that.
And thanks for the review!
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191128/eb372e45/attachment.sig>
next prev parent reply other threads:[~2019-11-28 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 10:12 [U-Boot] [PATCH 1/2] rockchip: px30: Fixup PMUGRF registers layout order Paul Kocialkowski
2019-11-27 10:12 ` [U-Boot] [PATCH 2/2] rockchip: px30: Add support for using UART3 as debug UART Paul Kocialkowski
2019-11-28 9:37 ` Kever Yang
2019-11-28 9:44 ` Heiko Stuebner
2019-11-28 9:51 ` Philipp Tomsich
2019-11-28 9:57 ` Paul Kocialkowski [this message]
2019-11-28 9:36 ` [U-Boot] [PATCH 1/2] rockchip: px30: Fixup PMUGRF registers layout order Kever Yang
2019-11-28 9:40 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128095748.GA257289@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox