From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] warp7: Fix U-Boot corruption after saving the environment
Date: Mon, 2 Dec 2019 22:10:29 -0500 [thread overview]
Message-ID: <20191203031029.GJ15966@bill-the-cat> (raw)
In-Reply-To: <20191203030446.5667-1-festevam@gmail.com>
On Tue, Dec 03, 2019 at 12:04:46AM -0300, Fabio Estevam wrote:
> U-Boot binary has grown in such a way that it goes beyond the reserved
> area for the environment variables.
>
> Running "saveenv" followed by a "reset" causes U-Boot to hang because
> of this overlap.
>
> Fix this problem by selecting CONFIG_SYS_THUMB_BUILD=y, which
> generates a smaller u-boot-dtb.imx binary.
>
> Also, in order to prevent this same problem in the future, use
> CONFIG_BOARD_SIZE_LIMIT, which will detect the overlap in build-time.
>
> CONFIG_BOARD_SIZE_LIMIT does not accept math expressions, so declare
> CONFIG_ENV_OFFSET with its direct value instead.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Thanks for the rework. Can you please look at what other i.MX boards
are likely fine, or perhaps more clearly if any i.MX5/6 SoCs do have
thumb2 related errata that might make it a bad idea to use thumb by
default ?
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191202/49b05a51/attachment.sig>
next prev parent reply other threads:[~2019-12-03 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 3:04 [U-Boot] [PATCH v3] warp7: Fix U-Boot corruption after saving the environment Fabio Estevam
2019-12-03 3:10 ` Tom Rini [this message]
2019-12-03 11:56 ` Fabio Estevam
2019-12-03 14:21 ` Tom Rini
2019-12-03 17:07 ` Heiko Schocher
2019-12-03 17:10 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203031029.GJ15966@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox