From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jorge Ramirez-Ortiz, Foundries <jorge@foundries.io>
Date: Tue, 3 Dec 2019 15:07:12 +0100
Subject: [PATCH] tools/imximage: fix reported DCD information for MX7ULP
In-Reply-To: <CAOMZO5A_kA=du0nQkDRzjmxXP1sUzEDF-SVRgNu4SdiM8YfQ7g@mail.gmail.com>
References: <20191128103321.7285-1-jorge@foundries.io>
 <CAOMZO5A_kA=du0nQkDRzjmxXP1sUzEDF-SVRgNu4SdiM8YfQ7g@mail.gmail.com>
Message-ID: <20191203140711.GA24787@trex>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/12/19 10:42:13, Fabio Estevam wrote:
> Hi Jorge,
> 
> Adding Breno.
> 
> On Thu, Nov 28, 2019 at 7:33 AM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
> >
> > On the MX7ULP, OCRAM for DCD is at 0x2f010000
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> > ---
> >  tools/imximage.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/imximage.c b/tools/imximage.c
> > index d7c0b6e883..762a06d468 100644
> > --- a/tools/imximage.c
> > +++ b/tools/imximage.c
> > @@ -11,6 +11,7 @@
> >  #include "imagetool.h"
> >  #include <image.h>
> >  #include "imximage.h"
> > +#include <generated/autoconf.h>
> >
> >  #define UNDEFINED 0xFFFFFFFF
> >
> > @@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
> >                         printf("HAB Blocks:   0x%08x 0x%08x 0x%08x\n",
> >                                (uint32_t)fhdr_v2->self, 0,
> >                                (uint32_t)(fhdr_v2->csf - fhdr_v2->self));
> > +#ifndef CONFIG_MX7ULP
> >                         printf("DCD Blocks:   0x00910000 0x%08x 0x%08x\n",
> >                                offs, be16_to_cpu(dcdlen));
> > +#else
> > +                       printf("DCD Blocks:   0x2f010000 0x%08x 0x%08x\n",
> > +                              offs, be16_to_cpu(dcdlen));
> > +#endif
> 
> Can we make the DCD OCRAM a variable passed via Kconfig and selected
> by SoC type?
> 
> This way we don't need to keep changing this for future SoCs.
> 
> What do you think?

sure that would work. given that the default 0x00910000 is valid on
most of the cases - well all but the mx7ulp - we could apply this default and only change to the
Kconfig value if defined.

should we go for that?