public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [PATCH v2 01/12] phy: atheros: Make RGMII Tx delays actually configurable for AR8035
Date: Thu,  5 Dec 2019 23:57:31 +0100	[thread overview]
Message-ID: <20191205225742.26152-2-michael@walle.cc> (raw)
In-Reply-To: <20191205225742.26152-1-michael@walle.cc>

From: Vladimir Oltean <vladimir.oltean@nxp.com>

Delete the extraneous write to debug reg 5 that enables Tx delay

When the driver was originally introduced in commit "6027384a phylib:
Add Atheros AR8035 GETH PHY support", the Tx delay was being
unconditionally enabled.

Then during "2ec4d10b phy: atheros: add support for RGMII_ID, RGMII_TXID
and RGMII_RXID", the author did not notice that code for enabling Tx
delay code was already. Therefore, the if condition for Tx delay has
always been useless for this PHY since this commit introduced it.

Prior to this patch, every AR8035 PHY in U-boot had Tx delay enabled.
After this patch, only those who define the interface as RGMII_TXID or
RGMII_ID will. This is to be expected, but will nonetheless break the
setups of those who didn't know they rely on Tx delay implicitly.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
 drivers/net/phy/atheros.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index 3783d155e7..537c1a9125 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -63,10 +63,6 @@ static int ar8035_config(struct phy_device *phydev)
 	regval = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
 	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, (regval|0x0018));
 
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
-	regval = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, (regval|0x0100));
-
 	if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
 	    (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)) {
 		/* select debug reg 5 */
-- 
2.20.1

  reply	other threads:[~2019-12-05 22:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 22:57 [PATCH v2 00/12] phy: atheros: dt bindings and cleanup Michael Walle
2019-12-05 22:57 ` Michael Walle [this message]
2019-12-05 22:57 ` [PATCH v2 02/12] phy: atheros: Use common functions for RGMII internal delays Michael Walle
2019-12-05 22:57 ` [PATCH v2 03/12] phy: atheros: Clarify the configuration of the CLK_25M output pin Michael Walle
2019-12-05 22:57 ` [PATCH v2 04/12] phy: atheros: Explicitly disable RGMII delays Michael Walle
2019-12-05 22:57 ` [PATCH v2 05/12] phy: atheros: Clarify the intention of ar8021_config Michael Walle
2019-12-05 22:57 ` [PATCH v2 06/12] phy: atheros: fix AR8021 PHY ID mask Michael Walle
2020-03-05 22:56   ` Joe Hershberger
2019-12-05 22:57 ` [PATCH v2 07/12] phy: atheros: use defines for PHY IDs Michael Walle
2019-12-05 22:57 ` [PATCH v2 08/12] phy: atheros: introduce debug read and write functions Michael Walle
2020-03-05 23:06   ` Joe Hershberger
2019-12-05 22:57 ` [PATCH v2 09/12] phy: atheros: move delay config to common function Michael Walle
2020-03-05 23:08   ` Joe Hershberger
2019-12-05 22:57 ` [PATCH v2 10/12] phy: atheros: add device tree bindings and config Michael Walle
2020-03-05 23:09   ` Joe Hershberger
2019-12-05 22:57 ` [PATCH v2 11/12] phy: atheros: ar8035: remove static clock config Michael Walle
2020-03-05 23:10   ` Joe Hershberger
2019-12-05 22:57 ` [PATCH v2 12/12] phy: atheros: consolidate {ar8031|ar8035}_config() Michael Walle
2020-03-05 23:10   ` Joe Hershberger
2020-01-07 11:07 ` [PATCH v2 00/12] phy: atheros: dt bindings and cleanup Michael Walle
2020-03-10 17:46   ` Joe Hershberger
2020-03-10 17:55     ` Tom Rini
2020-03-27 18:07       ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205225742.26152-2-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox