* [PATCH] Makefile: Ensure tools directory exists in output prior to use
@ 2019-12-04 23:54 Tom Rini
2019-12-05 1:23 ` Bin Meng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Rini @ 2019-12-04 23:54 UTC (permalink / raw)
To: u-boot
With the change to make tools/version.h a file we need to make sure that
the output directory exists first otherwise we will get a build failure.
Reported-by: Peter Robinson <pbrobinson@gmail.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 0ee0c701022a..960926caad45 100644
--- a/Makefile
+++ b/Makefile
@@ -1889,6 +1889,7 @@ checkarmreloc: u-boot
fi
tools/version.h: include/version.h
+ $(Q)mkdir -p $(dir $@)
$(call if_changed,copy)
envtools: scripts_basic $(version_h) $(timestamp_h) tools/version.h
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] Makefile: Ensure tools directory exists in output prior to use
2019-12-04 23:54 [PATCH] Makefile: Ensure tools directory exists in output prior to use Tom Rini
@ 2019-12-05 1:23 ` Bin Meng
2019-12-06 4:59 ` Simon Glass
2019-12-06 21:50 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-12-05 1:23 UTC (permalink / raw)
To: u-boot
On Thu, Dec 5, 2019 at 7:54 AM Tom Rini <trini@konsulko.com> wrote:
>
> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
>
> Reported-by: Peter Robinson <pbrobinson@gmail.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Makefile: Ensure tools directory exists in output prior to use
2019-12-04 23:54 [PATCH] Makefile: Ensure tools directory exists in output prior to use Tom Rini
2019-12-05 1:23 ` Bin Meng
@ 2019-12-06 4:59 ` Simon Glass
2019-12-06 21:50 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2019-12-06 4:59 UTC (permalink / raw)
To: u-boot
On Wed, 4 Dec 2019 at 16:54, Tom Rini <trini@konsulko.com> wrote:
>
> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
>
> Reported-by: Peter Robinson <pbrobinson@gmail.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Makefile: Ensure tools directory exists in output prior to use
2019-12-04 23:54 [PATCH] Makefile: Ensure tools directory exists in output prior to use Tom Rini
2019-12-05 1:23 ` Bin Meng
2019-12-06 4:59 ` Simon Glass
@ 2019-12-06 21:50 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2019-12-06 21:50 UTC (permalink / raw)
To: u-boot
On Wed, Dec 04, 2019 at 06:54:30PM -0500, Tom Rini wrote:
> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
>
> Reported-by: Peter Robinson <pbrobinson@gmail.com>
> Tested-by: Peter Robinson <pbrobinson@gmail.com>
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191206/2a847eb1/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-06 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-04 23:54 [PATCH] Makefile: Ensure tools directory exists in output prior to use Tom Rini
2019-12-05 1:23 ` Bin Meng
2019-12-06 4:59 ` Simon Glass
2019-12-06 21:50 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox