public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 03/20] clk: imx: pllv3: register PLLV3 GENERIC and USB as 2 different clocks
Date: Sun, 8 Dec 2019 15:33:34 +0100	[thread overview]
Message-ID: <20191208153334.1a72dcaa@jawa> (raw)
In-Reply-To: <20191204174439.69934-4-giulio.benetti@benettiengineering.com>

On Wed,  4 Dec 2019 18:44:22 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Better to register the 2 clock as 2 different drivers because they
> work slightly differently depending on power_bit and powerup_set bits
> coming on next patches.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  drivers/clk/imx/clk-pllv3.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index fbb7b24d5e..d1e4c3fe30 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -13,7 +13,8 @@
>  #include <clk.h>
>  #include "clk.h"
>  
> -#define UBOOT_DM_CLK_IMX_PLLV3 "imx_clk_pllv3"
> +#define UBOOT_DM_CLK_IMX_PLLV3_GENERIC	"imx_clk_pllv3_generic"
> +#define UBOOT_DM_CLK_IMX_PLLV3_USB	"imx_clk_pllv3_usb"
>  
>  struct clk_pllv3 {
>  	struct clk	clk;
> @@ -24,7 +25,7 @@ struct clk_pllv3 {
>  
>  #define to_clk_pllv3(_clk) container_of(_clk, struct clk_pllv3, clk)
>  
> -static ulong clk_pllv3_get_rate(struct clk *clk)
> +static ulong clk_pllv3_generic_get_rate(struct clk *clk)
>  {
>  	struct clk_pllv3 *pll =
> to_clk_pllv3(dev_get_clk_ptr(clk->dev)); unsigned long parent_rate =
> clk_get_parent_rate(clk); @@ -35,7 +36,7 @@ static ulong
> clk_pllv3_get_rate(struct clk *clk) }
>  
>  static const struct clk_ops clk_pllv3_generic_ops = {
> -	.get_rate       = clk_pllv3_get_rate,
> +	.get_rate	= clk_pllv3_generic_get_rate,
>  };
>  
>  struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name,
> @@ -53,8 +54,10 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type
> type, const char *name, 
>  	switch (type) {
>  	case IMX_PLLV3_GENERIC:
> +		drv_name = UBOOT_DM_CLK_IMX_PLLV3_GENERIC;
> +		break;
>  	case IMX_PLLV3_USB:
> -		drv_name = UBOOT_DM_CLK_IMX_PLLV3;
> +		drv_name = UBOOT_DM_CLK_IMX_PLLV3_USB;
>  		break;
>  	default:
>  		kfree(pll);
> @@ -75,7 +78,14 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type
> type, const char *name, }
>  
>  U_BOOT_DRIVER(clk_pllv3_generic) = {
> -	.name	= UBOOT_DM_CLK_IMX_PLLV3,
> +	.name	= UBOOT_DM_CLK_IMX_PLLV3_GENERIC,
> +	.id	= UCLASS_CLK,
> +	.ops	= &clk_pllv3_generic_ops,
> +	.flags = DM_FLAG_PRE_RELOC,
> +};
> +
> +U_BOOT_DRIVER(clk_pllv3_usb) = {
> +	.name	= UBOOT_DM_CLK_IMX_PLLV3_USB,
>  	.id	= UCLASS_CLK,
>  	.ops	= &clk_pllv3_generic_ops,
>  	.flags = DM_FLAG_PRE_RELOC,

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191208/2f3b2539/attachment.sig>

  reply	other threads:[~2019-12-08 14:33 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 17:44 [PATCH 00/20] Add i.MXRT family support Giulio Benetti
2019-12-04 17:44 ` [PATCH 01/20] armv7m: cache: add mmu_set_region_dcache_behaviour() stub for compatibility Giulio Benetti
2019-12-04 17:44 ` [PATCH 02/20] spl: fix entry_point equal to load_addr Giulio Benetti
2019-12-08 14:37   ` Lukasz Majewski
2019-12-09 10:47     ` Giulio Benetti
2019-12-04 17:44 ` [PATCH 03/20] clk: imx: pllv3: register PLLV3 GENERIC and USB as 2 different clocks Giulio Benetti
2019-12-08 14:33   ` Lukasz Majewski [this message]
2019-12-04 17:44 ` [PATCH 04/20] clk: imx: pllv3: set div_mask differently if PLLV3 is GENERIC or USB Giulio Benetti
2019-12-08 14:32   ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 05/20] clk: imx: pllv3: add enable() support Giulio Benetti
2019-12-04 17:44 ` [PATCH 06/20] clk: imx: pllv3: add disable() support Giulio Benetti
2019-12-08 14:27   ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 07/20] clk: imx: pllv3: add set_rate() support Giulio Benetti
2019-12-08 14:27   ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 08/20] clk: imx: pllv3: add PLLV3_SYS support Giulio Benetti
2019-12-08 14:28   ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 09/20] clk: imx: pllv3: add support for PLLV3_AV type Giulio Benetti
2019-12-08 15:05   ` Lukasz Majewski
2019-12-09 17:13     ` Giulio Benetti
2019-12-10  0:07       ` Lukasz Majewski
2019-12-11 12:47         ` Giulio Benetti
2019-12-12 10:05           ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 10/20] clk: imx: pfd: add set_rate() Giulio Benetti
2019-12-08 14:38   ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 11/20] clk: imx: add i.IMXRT1050 clk driver Giulio Benetti
2019-12-08 14:40   ` Lukasz Majewski
2019-12-09 10:49     ` Giulio Benetti
2019-12-09 10:53       ` Giulio Benetti
2019-12-09 23:36         ` Lukasz Majewski
2019-12-11 12:30           ` Giulio Benetti
2019-12-04 17:44 ` [PATCH 12/20] pinctrl: add i.MXRT driver Giulio Benetti
2019-12-08 14:45   ` Lukasz Majewski
2019-12-09 11:54     ` Giulio Benetti
2019-12-09 23:46       ` Lukasz Majewski
2019-12-11 12:40         ` Giulio Benetti
2019-12-11 23:46           ` Lukasz Majewski
2019-12-04 17:44 ` [PATCH 13/20] ARM: dts: imxrt1050: add dtsi file Giulio Benetti
2019-12-04 23:01   ` Giulio Benetti
2019-12-08 14:46   ` Lukasz Majewski
2019-12-09 10:51     ` Giulio Benetti
2019-12-04 17:44 ` [PATCH 14/20] serial_lpuart: add clock enable if CONFIG_CLK is defined Giulio Benetti
2019-12-08 14:52   ` Lukasz Majewski
2019-12-09 15:20     ` Giulio Benetti
2019-12-09 23:48       ` Lukasz Majewski
2019-12-17 18:37         ` Giulio Benetti
2019-12-30  1:21           ` Simon Glass
2019-12-04 17:44 ` [PATCH 15/20] serial_lpuart: add support for i.MXRT Giulio Benetti
2019-12-08 14:58   ` Lukasz Majewski
2019-12-09 12:56     ` Giulio Benetti
2020-01-03 11:39 ` [PATCH 00/20] Add i.MXRT family support Stefano Babic
2020-01-03 14:14   ` Giulio Benetti
2020-01-07 17:23   ` Giulio Benetti
2020-01-08 17:39     ` Simon Glass
2020-01-08 17:53       ` Giulio Benetti
2020-01-09 20:04         ` Simon Glass
2020-01-10 14:05           ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191208153334.1a72dcaa@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox