* [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion
@ 2019-12-10 9:32 Fabio Estevam
2019-12-10 9:33 ` [PATCH v3 2/2] wandboard: Remove repeated PMIC string Fabio Estevam
2019-12-28 10:48 ` [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion sbabic at denx.de
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-12-10 9:32 UTC (permalink / raw)
To: u-boot
Commit ec837c82d709 ("imx6: wandboard: convert to DM_PMIC")
caused the following pmic_get() error:
CPU: Freescale i.MX6QP rev1.0 at 792 MHz
Reset cause: POR
DRAM: 2 GiB
PMIC: pmic_get() ret -19
...
and since the PMIC presence is used to determine the board D1 revision,
the following error is seen when booting a board rev D1:
WARNING: Could not determine dtb to use
and the kernel does not boot at all.
Fix the regression by passing "pfuze100 at 8" as the correct parameter
to the pmic_get() function in the DM case.
Fixes: ec837c82d709 ("imx6: wandboard: convert to DM_PMIC")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- None
board/wandboard/wandboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 6c1e4ef27d..b2f961a7f0 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -363,7 +363,7 @@ int power_init_board(void)
puts("PMIC: ");
- ret = pmic_get("pfuze100", &dev);
+ ret = pmic_get("pfuze100 at 8", &dev);
if (ret < 0) {
printf("pmic_get() ret %d\n", ret);
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] wandboard: Remove repeated PMIC string
2019-12-10 9:32 [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion Fabio Estevam
@ 2019-12-10 9:33 ` Fabio Estevam
2019-12-28 10:48 ` sbabic at denx.de
2019-12-28 10:48 ` [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion sbabic at denx.de
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-12-10 9:33 UTC (permalink / raw)
To: u-boot
After the conversion to DM_PMIC the following output is seen:
PMIC: PMIC: PFUZE100 ID=0x10
Remove the unnecessary PMIC string from the board file to
avoid the repetead string.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- None
board/wandboard/wandboard.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 7209cc8211..e386ad2cc1 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -361,8 +361,6 @@ int power_init_board(void)
struct udevice *dev;
int reg, ret;
- puts("PMIC: ");
-
ret = pmic_get("pfuze100 at 8", &dev);
if (ret < 0) {
printf("pmic_get() ret %d\n", ret);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] wandboard: Remove repeated PMIC string
2019-12-10 9:33 ` [PATCH v3 2/2] wandboard: Remove repeated PMIC string Fabio Estevam
@ 2019-12-28 10:48 ` sbabic at denx.de
0 siblings, 0 replies; 5+ messages in thread
From: sbabic at denx.de @ 2019-12-28 10:48 UTC (permalink / raw)
To: u-boot
> After the conversion to DM_PMIC the following output is seen:
> PMIC: PMIC: PFUZE100 ID=0x10
> Remove the unnecessary PMIC string from the board file to
> avoid the repetead string.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion
2019-12-10 9:32 [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion Fabio Estevam
2019-12-10 9:33 ` [PATCH v3 2/2] wandboard: Remove repeated PMIC string Fabio Estevam
@ 2019-12-28 10:48 ` sbabic at denx.de
1 sibling, 0 replies; 5+ messages in thread
From: sbabic at denx.de @ 2019-12-28 10:48 UTC (permalink / raw)
To: u-boot
> Commit ec837c82d709 ("imx6: wandboard: convert to DM_PMIC")
> caused the following pmic_get() error:
>
> CPU: Freescale i.MX6QP rev1.0 at 792 MHz
> Reset cause: POR
> DRAM: 2 GiB
> PMIC: pmic_get() ret -19
> ...
> and since the PMIC presence is used to determine the board D1 revision,
> the following error is seen when booting a board rev D1:
>
> WARNING: Could not determine dtb to use
> and the kernel does not boot at all.
> Fix the regression by passing "pfuze100 at 8" as the correct parameter
> to the pmic_get() function in the DM case.
> Fixes: ec837c82d709 ("imx6: wandboard: convert to DM_PMIC")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] wandboard: Remove repeated PMIC string
2020-04-17 0:10 [PATCH 1/5] wandboard: Fix detection for mx6q/mx6dl revD1 revariants Fabio Estevam
@ 2020-04-17 0:10 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-04-17 0:10 UTC (permalink / raw)
To: u-boot
After the conversion to DM_PMIC the following output is seen:
PMIC: PMIC: PFUZE100 ID=0x10
Remove the unnecessary PMIC string from the board file to
avoid the repetead string.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- None
board/wandboard/wandboard.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 7209cc8211..e386ad2cc1 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -361,8 +361,6 @@ int power_init_board(void)
struct udevice *dev;
int reg, ret;
- puts("PMIC: ");
-
ret = pmic_get("pfuze100 at 8", &dev);
if (ret < 0) {
printf("pmic_get() ret %d\n", ret);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-17 0:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 9:32 [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion Fabio Estevam
2019-12-10 9:33 ` [PATCH v3 2/2] wandboard: Remove repeated PMIC string Fabio Estevam
2019-12-28 10:48 ` sbabic at denx.de
2019-12-28 10:48 ` [PATCH v3 1/2] wandboard: Fix the DM_PMIC conversion sbabic at denx.de
-- strict thread matches above, loose matches on Subject: below --
2020-04-17 0:10 [PATCH 1/5] wandboard: Fix detection for mx6q/mx6dl revD1 revariants Fabio Estevam
2020-04-17 0:10 ` [PATCH v3 2/2] wandboard: Remove repeated PMIC string Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox