public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level
@ 2019-12-11 20:37 Fabio Estevam
  2019-12-12  1:21 ` Peng Fan
  2019-12-28 10:48 ` sbabic at denx.de
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-12-11 20:37 UTC (permalink / raw)
  To: u-boot

Currently inside ddr_init() there is a mix of printf() and debug()
level messages.

Since this type of information is useful for debug purposes,
convert all of them to debug level for consistency.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ddr/imx/imx8m/ddr_init.c b/drivers/ddr/imx/imx8m/ddr_init.c
index d6e915c9b9..21af66e4e7 100644
--- a/drivers/ddr/imx/imx8m/ddr_init.c
+++ b/drivers/ddr/imx/imx8m/ddr_init.c
@@ -24,7 +24,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 {
 	unsigned int tmp, initial_drate, target_freq;
 
-	printf("DDRINFO: start DRAM init\n");
+	debug("DDRINFO: start DRAM init\n");
 
 	/* Step1: Follow the power up procedure */
 	if (is_imx8mq()) {
@@ -109,7 +109,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 		tmp = reg32_read(DDRPHY_CalBusy(0));
 	} while ((tmp & 0x1));
 
-	printf("DDRINFO:ddrphy calibration done\n");
+	debug("DDRINFO:ddrphy calibration done\n");
 
 	/* Step15: Set SWCTL.sw_done to 0 */
 	reg32_write(DDRC_SWCTL(0), 0x00000000);
@@ -161,7 +161,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 
 	/* enable port 0 */
 	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
-	printf("DDRINFO: ddrmix config done\n");
+	debug("DDRINFO: ddrmix config done\n");
 
 	/* save the dram timing config into memory */
 	dram_config_save(dram_timing, CONFIG_SAVED_DRAM_TIMING_BASE);
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level
  2019-12-11 20:37 [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level Fabio Estevam
@ 2019-12-12  1:21 ` Peng Fan
  2019-12-28 10:48 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-12-12  1:21 UTC (permalink / raw)
  To: u-boot

> Subject: [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level
> 
> Currently inside ddr_init() there is a mix of printf() and debug() level messages.
> 
> Since this type of information is useful for debug purposes, convert all of them
> to debug level for consistency.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ddr/imx/imx8m/ddr_init.c
> b/drivers/ddr/imx/imx8m/ddr_init.c
> index d6e915c9b9..21af66e4e7 100644
> --- a/drivers/ddr/imx/imx8m/ddr_init.c
> +++ b/drivers/ddr/imx/imx8m/ddr_init.c
> @@ -24,7 +24,7 @@ void ddr_init(struct dram_timing_info *dram_timing)  {
>  	unsigned int tmp, initial_drate, target_freq;
> 
> -	printf("DDRINFO: start DRAM init\n");
> +	debug("DDRINFO: start DRAM init\n");
> 
>  	/* Step1: Follow the power up procedure */
>  	if (is_imx8mq()) {
> @@ -109,7 +109,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
>  		tmp = reg32_read(DDRPHY_CalBusy(0));
>  	} while ((tmp & 0x1));
> 
> -	printf("DDRINFO:ddrphy calibration done\n");
> +	debug("DDRINFO:ddrphy calibration done\n");
> 
>  	/* Step15: Set SWCTL.sw_done to 0 */
>  	reg32_write(DDRC_SWCTL(0), 0x00000000); @@ -161,7 +161,7 @@
> void ddr_init(struct dram_timing_info *dram_timing)
> 
>  	/* enable port 0 */
>  	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
> -	printf("DDRINFO: ddrmix config done\n");
> +	debug("DDRINFO: ddrmix config done\n");
> 
>  	/* save the dram timing config into memory */
>  	dram_config_save(dram_timing,
> CONFIG_SAVED_DRAM_TIMING_BASE);
> --
> 2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level
  2019-12-11 20:37 [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level Fabio Estevam
  2019-12-12  1:21 ` Peng Fan
@ 2019-12-28 10:48 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2019-12-28 10:48 UTC (permalink / raw)
  To: u-boot

> Currently inside ddr_init() there is a mix of printf() and debug()
> level messages.
> Since this type of information is useful for debug purposes,
> convert all of them to debug level for consistency.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-28 10:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 20:37 [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level Fabio Estevam
2019-12-12  1:21 ` Peng Fan
2019-12-28 10:48 ` sbabic at denx.de

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox