From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 25/35] image: Rename load_addr, save_addr, save_size
Date: Thu, 12 Dec 2019 09:25:46 -0500 [thread overview]
Message-ID: <20191212142546.GG9549@bill-the-cat> (raw)
In-Reply-To: <20191211174637.25.Iae8516460419c864d915f5635b236279ea087504@changeid>
On Wed, Dec 11, 2019 at 05:47:44PM -0700, Simon Glass wrote:
> These global variables are quite short and generic. In fact the same name
> is more often used locally for struct members and function arguments.
>
> Add a image_ prefix to make them easier to distinguish.
I'm not so sure about this patch:
[snip]
> diff --git a/common/image.c b/common/image.c
> index eb626dcac9..877c97839b 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -556,9 +556,9 @@ static const image_header_t *image_get_ramdisk(ulong rd_addr, uint8_t arch,
> /* Shared dual-format routines */
> /*****************************************************************************/
> #ifndef USE_HOSTCC
> -ulong load_addr = CONFIG_SYS_LOAD_ADDR; /* Default Load Address */
It's the default safe to load whatever to address. It's not just for
"images". It is the generic'ist load address.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191212/26912b54/attachment.sig>
next prev parent reply other threads:[~2019-12-12 14:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 0:47 [PATCH 01/35] common: Drop mdm_init() Simon Glass
2019-12-12 0:47 ` [PATCH 02/35] common: Move main_loop() to init.h Simon Glass
2019-12-12 8:20 ` Simon Goldschmidt
2019-12-12 8:32 ` Simon Goldschmidt
2019-12-12 9:00 ` email address of Boris Brezillon Heinrich Schuchardt
2019-12-12 9:51 ` Boris Brezillon
2019-12-27 16:42 ` [PATCH 02/35] common: Move main_loop() to init.h Simon Glass
2019-12-12 0:47 ` [PATCH 03/35] common: Move flash_perror() to flash.h Simon Glass
2019-12-12 0:47 ` [PATCH 04/35] common: Drop checkflash() and checkdram() Simon Glass
2019-12-12 0:47 ` [PATCH 05/35] common: Move embedded fdt location to fdtdec.h Simon Glass
2019-12-12 0:47 ` [PATCH 06/35] common: Move do_tftpb() to net.h Simon Glass
2019-12-12 0:47 ` [PATCH 07/35] common: Move functions for loading from fat/ext2 to fs.h Simon Glass
2019-12-12 8:31 ` Heinrich Schuchardt
2019-12-12 14:10 ` Tom Rini
2019-12-12 0:47 ` [PATCH 08/35] common: Move relocate_code() to init.h Simon Glass
2019-12-12 0:51 ` Timur Tabi
2019-12-12 0:47 ` [PATCH 09/35] common: Move jumptable_init() out of common.h Simon Glass
2019-12-12 8:39 ` Heinrich Schuchardt
2019-12-12 0:47 ` [PATCH 10/35] common: Drop floppy disk support Simon Glass
2019-12-12 0:47 ` [PATCH 11/35] common: Move reset_phy() to net.h Simon Glass
2019-12-12 0:47 ` [PATCH 12/35] common: Move CONFIG_SYS_DEF_EEPROM_ADDR out of common.h Simon Glass
2019-12-12 0:47 ` [PATCH 13/35] common: Drop CONFIG_POST_STD/ALT_LIST Simon Glass
2019-12-12 0:47 ` [PATCH 14/35] common: Drop CONFIG_HAS_POST Simon Glass
2019-12-12 13:59 ` Tom Rini
2019-12-27 16:42 ` Simon Glass
2020-01-10 14:17 ` Tom Rini
2019-12-12 0:47 ` [PATCH 15/35] common: Drop the symbol_lookup() declaration Simon Glass
2019-12-12 0:47 ` [PATCH 16/35] common: Move type declarations to linux/types.h Simon Glass
2019-12-12 8:19 ` Heinrich Schuchardt
2019-12-12 0:47 ` [PATCH 17/35] common: Move device-tree setup functions to fdt_support.h Simon Glass
2019-12-12 0:47 ` [PATCH 18/35] common: arm: Move s_init() to an ARM-specific header Simon Glass
2019-12-12 0:47 ` [PATCH 19/35] common: Move ll_boot_init() to init.h Simon Glass
2019-12-12 0:47 ` [PATCH 20/35] common: Move upmconfig() to ppc.h Simon Glass
2019-12-12 0:47 ` [PATCH 21/35] common: Move clock functions into a new file Simon Glass
2019-12-12 0:47 ` [PATCH 22/35] common: Move get_tbclk() to time.h Simon Glass
2019-12-12 0:47 ` [PATCH 23/35] common: Move reset_misc() function to arch header Simon Glass
2019-12-12 0:47 ` [PATCH 24/35] common: Move reset_cpu() to the CPU header Simon Glass
2019-12-12 0:47 ` [PATCH 25/35] image: Rename load_addr, save_addr, save_size Simon Glass
2019-12-12 14:25 ` Tom Rini [this message]
2019-12-12 0:47 ` [PATCH 26/35] common: Move the image globals into image.h Simon Glass
2019-12-12 0:47 ` [PATCH 27/35] common: Rename and move source() Simon Glass
2019-12-12 0:47 ` [PATCH 28/35] common: Move RAM-sizing functions to init.h Simon Glass
2019-12-12 0:47 ` [PATCH 29/35] common: Move testdram() into init.h Simon Glass
2019-12-12 0:47 ` [PATCH 30/35] common: Move hang() to the same header as panic() Simon Glass
2019-12-12 0:47 ` [PATCH 31/35] common: Move check_member() to kernel.h Simon Glass
2019-12-12 0:47 ` [PATCH 32/35] common: Move ROUND() into kernel.h Simon Glass
2019-12-12 0:47 ` [PATCH 33/35] common: Move and rename CONFIG_SYS_SUPPORT_64BIT_DATA Simon Glass
2019-12-12 14:02 ` Tom Rini
2019-12-12 0:47 ` [PATCH 34/35] common: Collect all the header files together Simon Glass
2019-12-12 0:47 ` [PATCH 35/35] common: Update comment to show progress Simon Glass
2019-12-12 8:10 ` [PATCH 01/35] common: Drop mdm_init() Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212142546.GG9549@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox