* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
@ 2019-12-12 22:53 Giulio Benetti
2019-12-12 23:02 ` Giulio Benetti
0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2019-12-12 22:53 UTC (permalink / raw)
To: u-boot
clk_get_by_name() requires clk_get_by_id() that is not available if
CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else
condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
drivers/clk/clk-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
index 9aa8537004..170e19db65 100644
--- a/drivers/clk/clk-uclass.c
+++ b/drivers/clk/clk-uclass.c
@@ -326,7 +326,6 @@ int clk_set_defaults(struct udevice *dev, int stage)
return 0;
}
-# endif /* OF_PLATDATA */
int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
{
@@ -343,6 +342,7 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
return clk_get_by_index(dev, index, clk);
}
+# endif /* OF_PLATDATA */
int clk_release_all(struct clk *clk, int count)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-12 22:53 [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled Giulio Benetti
@ 2019-12-12 23:02 ` Giulio Benetti
2019-12-13 10:09 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2019-12-12 23:02 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On 12/12/19 11:53 PM, Giulio Benetti wrote:
> clk_get_by_name() requires clk_get_by_id() that is not available if
> CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else
> condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
I've already successfully executed a complete Travis with master and
this patch applied:
https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Kind regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> drivers/clk/clk-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 9aa8537004..170e19db65 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -326,7 +326,6 @@ int clk_set_defaults(struct udevice *dev, int stage)
>
> return 0;
> }
> -# endif /* OF_PLATDATA */
>
> int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
> {
> @@ -343,6 +342,7 @@ int clk_get_by_name(struct udevice *dev, const char *name, struct clk *clk)
>
> return clk_get_by_index(dev, index, clk);
> }
> +# endif /* OF_PLATDATA */
>
> int clk_release_all(struct clk *clk, int count)
> {
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-12 23:02 ` Giulio Benetti
@ 2019-12-13 10:09 ` Lukasz Majewski
2019-12-13 11:38 ` Giulio Benetti
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-12-13 10:09 UTC (permalink / raw)
To: u-boot
On Fri, 13 Dec 2019 00:02:25 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Hi Lukasz,
>
> On 12/12/19 11:53 PM, Giulio Benetti wrote:
> > clk_get_by_name() requires clk_get_by_id() that is not available if
> > CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else
> > condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
> >
> > Signed-off-by: Giulio Benetti
> > <giulio.benetti@benettiengineering.com>
>
> I've already successfully executed a complete Travis with master and
> this patch applied:
> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
Is this a preparatory patch for some other work? Or is it just a
standalone fix?
>
> Kind regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/af35b52e/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-13 10:09 ` Lukasz Majewski
@ 2019-12-13 11:38 ` Giulio Benetti
2019-12-13 13:42 ` Lukasz Majewski
2019-12-15 13:50 ` Lukasz Majewski
0 siblings, 2 replies; 8+ messages in thread
From: Giulio Benetti @ 2019-12-13 11:38 UTC (permalink / raw)
To: u-boot
On 12/13/19 11:09 AM, Lukasz Majewski wrote:
> On Fri, 13 Dec 2019 00:02:25 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>
>> Hi Lukasz,
>>
>> On 12/12/19 11:53 PM, Giulio Benetti wrote:
>>> clk_get_by_name() requires clk_get_by_id() that is not available if
>>> CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into #else
>>> condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
>>>
>>> Signed-off-by: Giulio Benetti
>>> <giulio.benetti@benettiengineering.com>
>>
>> I've already successfully executed a complete Travis with master and
>> this patch applied:
>> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
>
> Is this a preparatory patch for some other work? Or is it just a
> standalone fix?
This is a standalone fix.
Best regards
--
Giulio Benetti
Benetti Engineering sas
>>
>> Kind regards
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-13 11:38 ` Giulio Benetti
@ 2019-12-13 13:42 ` Lukasz Majewski
2019-12-15 13:50 ` Lukasz Majewski
1 sibling, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2019-12-13 13:42 UTC (permalink / raw)
To: u-boot
On Fri, 13 Dec 2019 12:38:43 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> On 12/13/19 11:09 AM, Lukasz Majewski wrote:
> > On Fri, 13 Dec 2019 00:02:25 +0100
> > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> >
> >> Hi Lukasz,
> >>
> >> On 12/12/19 11:53 PM, Giulio Benetti wrote:
> >>> clk_get_by_name() requires clk_get_by_id() that is not available
> >>> if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into
> >>> #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
> >>>
> >>> Signed-off-by: Giulio Benetti
> >>> <giulio.benetti@benettiengineering.com>
> >>
> >> I've already successfully executed a complete Travis with master
> >> and this patch applied:
> >> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
> >
> > Is this a preparatory patch for some other work? Or is it just a
> > standalone fix?
>
> This is a standalone fix.
>
Ok. Thanks for preparing it.
> Best regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191213/0f70069a/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-13 11:38 ` Giulio Benetti
2019-12-13 13:42 ` Lukasz Majewski
@ 2019-12-15 13:50 ` Lukasz Majewski
2019-12-15 15:09 ` Giulio Benetti
1 sibling, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-12-15 13:50 UTC (permalink / raw)
To: u-boot
Hi Giulio,
> On 12/13/19 11:09 AM, Lukasz Majewski wrote:
> > On Fri, 13 Dec 2019 00:02:25 +0100
> > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> >
> >> Hi Lukasz,
> >>
> >> On 12/12/19 11:53 PM, Giulio Benetti wrote:
> >>> clk_get_by_name() requires clk_get_by_id() that is not available
> >>> if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into
> >>> #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
> >>>
> >>> Signed-off-by: Giulio Benetti
> >>> <giulio.benetti@benettiengineering.com>
> >>
> >> I've already successfully executed a complete Travis with master
> >> and this patch applied:
> >> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
> >
> > Is this a preparatory patch for some other work? Or is it just a
> > standalone fix?
>
> This is a standalone fix.
As we are really close to final U-Boot release - I'm more keen to add
this patch to u-boot-clk -next repository.
Do you mind ?
>
> Best regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191215/f645f327/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-15 13:50 ` Lukasz Majewski
@ 2019-12-15 15:09 ` Giulio Benetti
2020-01-17 9:44 ` Giulio Benetti
0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2019-12-15 15:09 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On 12/15/19 2:50 PM, Lukasz Majewski wrote:
> Hi Giulio,
>
>> On 12/13/19 11:09 AM, Lukasz Majewski wrote:
>>> On Fri, 13 Dec 2019 00:02:25 +0100
>>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>>
>>>> Hi Lukasz,
>>>>
>>>> On 12/12/19 11:53 PM, Giulio Benetti wrote:
>>>>> clk_get_by_name() requires clk_get_by_id() that is not available
>>>>> if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into
>>>>> #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
>>>>>
>>>>> Signed-off-by: Giulio Benetti
>>>>> <giulio.benetti@benettiengineering.com>
>>>>
>>>> I've already successfully executed a complete Travis with master
>>>> and this patch applied:
>>>> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
>>>
>>> Is this a preparatory patch for some other work? Or is it just a
>>> standalone fix?
>>
>> This is a standalone fix.
>
> As we are really close to final U-Boot release - I'm more keen to add
> this patch to u-boot-clk -next repository.
>
> Do you mind ?
No problem at all, we'll see it "next"!
Best regards
--
Giulio Benetti
Benetti Engineering sas
>>
>> Best regards
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled
2019-12-15 15:09 ` Giulio Benetti
@ 2020-01-17 9:44 ` Giulio Benetti
0 siblings, 0 replies; 8+ messages in thread
From: Giulio Benetti @ 2020-01-17 9:44 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On 12/15/19 4:09 PM, Giulio Benetti wrote:
> Hi Lukasz,
>
> On 12/15/19 2:50 PM, Lukasz Majewski wrote:
>> Hi Giulio,
>>
>>> On 12/13/19 11:09 AM, Lukasz Majewski wrote:
>>>> On Fri, 13 Dec 2019 00:02:25 +0100
>>>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>>>
>>>>> Hi Lukasz,
>>>>>
>>>>> On 12/12/19 11:53 PM, Giulio Benetti wrote:
>>>>>> clk_get_by_name() requires clk_get_by_id() that is not available
>>>>>> if CONFIG_OF_PLATDATA is defined, so move clk_get_by_name() into
>>>>>> #else condition of #if CONFIG_IS_ENABLED(OF_PLATDATA).
>>>>>>
>>>>>> Signed-off-by: Giulio Benetti
>>>>>> <giulio.benetti@benettiengineering.com>
>>>>>
>>>>> I've already successfully executed a complete Travis with master
>>>>> and this patch applied:
>>>>> https://travis-ci.org/giuliobenetti/u-boot-imxrt/builds/624256888
>>>>
>>>> Is this a preparatory patch for some other work? Or is it just a
>>>> standalone fix?
>>>
>>> This is a standalone fix.
>>
>> As we are really close to final U-Boot release - I'm more keen to add
>> this patch to u-boot-clk -next repository.
>>
>> Do you mind ?
>
> No problem at all, we'll see it "next"!
>
> Best regards
>
Kindly ping
Best regards
--
Giulio Benetti
Benetti Engineering sas
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-17 9:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-12 22:53 [PATCH] clk: uclass: clk_get_by_name() must not be available if CONFIG_OF_PLATDATA is enabled Giulio Benetti
2019-12-12 23:02 ` Giulio Benetti
2019-12-13 10:09 ` Lukasz Majewski
2019-12-13 11:38 ` Giulio Benetti
2019-12-13 13:42 ` Lukasz Majewski
2019-12-15 13:50 ` Lukasz Majewski
2019-12-15 15:09 ` Giulio Benetti
2020-01-17 9:44 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox