public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v1] mach-imx: nandbcb: improve cmd help
@ 2019-12-16 12:06 Igor Opaniuk
  2019-12-19 14:15 ` Oleksandr Suvorov
  2020-01-04 11:03 ` sbabic at denx.de
  0 siblings, 2 replies; 3+ messages in thread
From: Igor Opaniuk @ 2019-12-16 12:06 UTC (permalink / raw)
  To: u-boot

From: Igor Opaniuk <igor.opaniuk@toradex.com>

Add info about supported i.MX7, improve details the usage of
bcbonly subcommand.

Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---

 arch/arm/mach-imx/cmd_nandbcb.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-imx/cmd_nandbcb.c b/arch/arm/mach-imx/cmd_nandbcb.c
index 9d3ed1aac3..334cc0766e 100644
--- a/arch/arm/mach-imx/cmd_nandbcb.c
+++ b/arch/arm/mach-imx/cmd_nandbcb.c
@@ -590,11 +590,14 @@ static char nandbcb_help_text[] =
 	"update addr off|partition len	- update 'len' bytes starting at\n"
 	"       'off|part' to memory address 'addr', skipping  bad blocks\n"
 	"bcbonly fw-size fw1-off [fw2-off] - write only BCB (FCB and DBBT)\n"
-	"       where `fw-size` is fw sizes in bytes, `fw1-off` and\n"
-	"       and `fw2-off` - firmware offsets		";
+	"       where `fw-size` is fw sizes in bytes, `fw1-off`\n"
+	"       and `fw2-off` - firmware offsets\n"
+	"       FIY, BCB isn't erased automatically, so mtd erase should\n"
+	"       be called in advance before writing new BCB:\n"
+	"           > mtd erase mx7-bcb";
 #endif
 
 U_BOOT_CMD(nandbcb, 5, 1, do_nandbcb,
-	   "i.MX6 Nand BCB",
+	   "i.MX6/i.MX7 NAND Boot Control Blocks write",
 	   nandbcb_help_text
 );
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v1] mach-imx: nandbcb: improve cmd help
  2019-12-16 12:06 [PATCH v1] mach-imx: nandbcb: improve cmd help Igor Opaniuk
@ 2019-12-19 14:15 ` Oleksandr Suvorov
  2020-01-04 11:03 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: Oleksandr Suvorov @ 2019-12-19 14:15 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 16, 2019 at 2:06 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> Add info about supported i.MX7, improve details the usage of
> bcbonly subcommand.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>
>  arch/arm/mach-imx/cmd_nandbcb.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-imx/cmd_nandbcb.c b/arch/arm/mach-imx/cmd_nandbcb.c
> index 9d3ed1aac3..334cc0766e 100644
> --- a/arch/arm/mach-imx/cmd_nandbcb.c
> +++ b/arch/arm/mach-imx/cmd_nandbcb.c
> @@ -590,11 +590,14 @@ static char nandbcb_help_text[] =
>         "update addr off|partition len  - update 'len' bytes starting at\n"
>         "       'off|part' to memory address 'addr', skipping  bad blocks\n"
>         "bcbonly fw-size fw1-off [fw2-off] - write only BCB (FCB and DBBT)\n"
> -       "       where `fw-size` is fw sizes in bytes, `fw1-off` and\n"
> -       "       and `fw2-off` - firmware offsets                ";
> +       "       where `fw-size` is fw sizes in bytes, `fw1-off`\n"
> +       "       and `fw2-off` - firmware offsets\n"
> +       "       FIY, BCB isn't erased automatically, so mtd erase should\n"
> +       "       be called in advance before writing new BCB:\n"
> +       "           > mtd erase mx7-bcb";
>  #endif
>
>  U_BOOT_CMD(nandbcb, 5, 1, do_nandbcb,
> -          "i.MX6 Nand BCB",
> +          "i.MX6/i.MX7 NAND Boot Control Blocks write",
>            nandbcb_help_text
>  );
> --
> 2.17.1
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1] mach-imx: nandbcb: improve cmd help
  2019-12-16 12:06 [PATCH v1] mach-imx: nandbcb: improve cmd help Igor Opaniuk
  2019-12-19 14:15 ` Oleksandr Suvorov
@ 2020-01-04 11:03 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2020-01-04 11:03 UTC (permalink / raw)
  To: u-boot

> From: Igor Opaniuk <igor.opaniuk@toradex.com>
> Add info about supported i.MX7, improve details the usage of
> bcbonly subcommand.
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Applied to u-boot-imx, -next, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-04 11:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-16 12:06 [PATCH v1] mach-imx: nandbcb: improve cmd help Igor Opaniuk
2019-12-19 14:15 ` Oleksandr Suvorov
2020-01-04 11:03 ` sbabic at denx.de

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox