* [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error
@ 2019-11-20 9:55 sunil.m at techveda.org
2019-11-20 9:55 ` [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH sunil.m at techveda.org
2019-12-29 10:26 ` [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sbabic at denx.de
0 siblings, 2 replies; 4+ messages in thread
From: sunil.m at techveda.org @ 2019-11-20 9:55 UTC (permalink / raw)
To: u-boot
From: Suniel Mahesh <sunil.m@techveda.org>
Enable driver model for Video to remove the following
compile warning on CM-FX6 SOM based target:
===================== WARNING ======================
This board does not use CONFIG_DM_VIDEO Please update
the board to use CONFIG_DM_VIDEO before the v2019.07 release.
====================================================
This change introduced build error as shown:
LD u-boot
drivers/built-in.o: In function ipu_displays_init'
arm-linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509
Makefile:1621: recipe for target 'u-boot' failed
make: *** [u-boot] Error 1
The DM converted video driver calls ipu_displays_init
in its probe, which inturn calls relevant board_video_skip.
Defining ipu_displays_init in the board file fixes build error.
Target was compile tested, build was clean.
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
board/compulab/cm_fx6/cm_fx6.c | 5 +++++
configs/cm_fx6_defconfig | 1 +
2 files changed, 6 insertions(+)
diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
index feb7a71..38dca2e 100644
--- a/board/compulab/cm_fx6/cm_fx6.c
+++ b/board/compulab/cm_fx6/cm_fx6.c
@@ -146,6 +146,11 @@ int board_video_skip(void)
static inline void cm_fx6_setup_display(void) {}
#endif /* CONFIG_VIDEO_IPUV3 */
+int ipu_displays_init(void)
+{
+ return board_video_skip();
+}
+
#ifdef CONFIG_DWC_AHSATA
static int cm_fx6_issd_gpios[] = {
/* The order of the GPIOs in the array is important! */
diff --git a/configs/cm_fx6_defconfig b/configs/cm_fx6_defconfig
index a27cdd7..8288095 100644
--- a/configs/cm_fx6_defconfig
+++ b/configs/cm_fx6_defconfig
@@ -86,4 +86,5 @@ CONFIG_USB_KEYBOARD=y
CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
CONFIG_VIDEO_IPUV3=y
CONFIG_VIDEO=y
+CONFIG_DM_VIDEO=y
CONFIG_FDT_FIXUP_PARTITIONS=y
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH
2019-11-20 9:55 [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sunil.m at techveda.org
@ 2019-11-20 9:55 ` sunil.m at techveda.org
2019-12-29 10:28 ` sbabic at denx.de
2019-12-29 10:26 ` [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sbabic at denx.de
1 sibling, 1 reply; 4+ messages in thread
From: sunil.m at techveda.org @ 2019-11-20 9:55 UTC (permalink / raw)
To: u-boot
From: Suniel Mahesh <sunil.m@techveda.org>
Enable CONFIG_DM_ETH to remove compile warning on CM-FX6
SOM based target:
===================== WARNING ======================
This board does not use CONFIG_DM_ETH (Driver Model
for Ethernet drivers). Please update the board to use
CONFIG_DM_ETH before the v2020.07 release.
====================================================
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
configs/cm_fx6_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/cm_fx6_defconfig b/configs/cm_fx6_defconfig
index 8288095..1eb288b 100644
--- a/configs/cm_fx6_defconfig
+++ b/configs/cm_fx6_defconfig
@@ -80,6 +80,7 @@ CONFIG_DM_REGULATOR=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
CONFIG_MXC_SPI=y
+CONFIG_DM_ETH=y
CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_KEYBOARD=y
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH
2019-11-20 9:55 ` [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH sunil.m at techveda.org
@ 2019-12-29 10:28 ` sbabic at denx.de
0 siblings, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2019-12-29 10:28 UTC (permalink / raw)
To: u-boot
> From: Suniel Mahesh <sunil.m@techveda.org>
> Enable CONFIG_DM_ETH to remove compile warning on CM-FX6
> SOM based target:
> ===================== WARNING ======================
> This board does not use CONFIG_DM_ETH (Driver Model
> for Ethernet drivers). Please update the board to use
> CONFIG_DM_ETH before the v2020.07 release.
> ====================================================
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Applied to u-boot-imx, -next, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error
2019-11-20 9:55 [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sunil.m at techveda.org
2019-11-20 9:55 ` [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH sunil.m at techveda.org
@ 2019-12-29 10:26 ` sbabic at denx.de
1 sibling, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2019-12-29 10:26 UTC (permalink / raw)
To: u-boot
> From: Suniel Mahesh <sunil.m@techveda.org>
> Enable driver model for Video to remove the following
> compile warning on CM-FX6 SOM based target:
> ===================== WARNING ======================
> This board does not use CONFIG_DM_VIDEO Please update
> the board to use CONFIG_DM_VIDEO before the v2019.07 release.
> ====================================================
> This change introduced build error as shown:
> LD u-boot
> drivers/built-in.o: In function ipu_displays_init'
> arm-linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509
> Makefile:1621: recipe for target 'u-boot' failed
> make: *** [u-boot] Error 1
> The DM converted video driver calls ipu_displays_init
> in its probe, which inturn calls relevant board_video_skip.
> Defining ipu_displays_init in the board file fixes build error.
> Target was compile tested, build was clean.
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Applied to u-boot-imx, -next, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-29 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-20 9:55 [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sunil.m at techveda.org
2019-11-20 9:55 ` [U-Boot] [PATCH 2/2] board: cm_fx6: Enable CONFIG_DM_ETH sunil.m at techveda.org
2019-12-29 10:28 ` sbabic at denx.de
2019-12-29 10:26 ` [U-Boot] [PATCH 1/2] board: cm_fx6: Enable DM support for video, fix build error sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox