public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] mmc: davinci: drop struct davinci_mmc_plat
Date: Fri, 3 Jan 2020 11:59:28 -0500	[thread overview]
Message-ID: <20200103165928.GR4866@bill-the-cat> (raw)
In-Reply-To: <CAMRc=McqS+YeVXsQUntyb=1YxSvpFbeDB7VZMMXiZQ9xiZ+aaA@mail.gmail.com>

On Fri, Jan 03, 2020 at 05:50:38PM +0100, Bartosz Golaszewski wrote:
> pt., 3 sty 2020 o 17:01 Adam Ford <aford173@gmail.com> napisał(a):
> >
> > On Thu, Nov 14, 2019 at 9:10 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > struct mmc_config & struct mmc don't need to be exported over platform
> > > data, but can instead be private in the driver.
> > >
> > > Remove struct davinci_mmc_plat.
> >
> > This patch appears to break the da850-evm.
> >
> > With the pending release of 2020.01, is there any way we can revert
> > before release and try to apply this going forward with more time to
> > test?
> >
> > As of now, the da850-evm cannot read/write from the MMC card from
> > U-Boot which includes MMC booting.
> >
> 
> This is strange, this change doesn't seem to affect the logic.
> 
> This isn't revertible automatically anymore, due to other patches that
> came before and after. We can probably try to revert it manually.

Doing a git revert and fixing up the one hunk that didn't go cleanly is
easy, should I push that?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200103/216cd8b3/attachment.sig>

  reply	other threads:[~2020-01-03 16:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 15:10 [U-Boot] [PATCH 0/4] omapl138_lcdk: fix MMC boot Bartosz Golaszewski
2019-11-14 15:10 ` [U-Boot] [PATCH 1/4] mmc: davinci: drop support for ti,dm6441-mmc Bartosz Golaszewski
2019-12-04  4:01   ` [U-Boot] [PATCH 1/4] mmc: davinci: drop support for ti, dm6441-mmc Tom Rini
2019-11-14 15:10 ` [U-Boot] [PATCH 2/4] mmc: davinci: drop struct davinci_mmc_plat Bartosz Golaszewski
2019-12-04  4:01   ` Tom Rini
2020-01-03 16:01   ` Adam Ford
2020-01-03 16:50     ` Bartosz Golaszewski
2020-01-03 16:59       ` Tom Rini [this message]
2020-01-03 17:26         ` Adam Ford
2019-11-14 15:10 ` [U-Boot] [PATCH 3/4] board: omapl138_lcdk: add the mmc device to SPL Bartosz Golaszewski
2019-12-04  4:02   ` Tom Rini
2019-11-14 15:10 ` [U-Boot] [PATCH 4/4] mmc: davinci: fix mmc boot in SPL Bartosz Golaszewski
2019-12-04  4:02   ` Tom Rini
2019-12-02  9:32 ` [U-Boot] [PATCH 0/4] omapl138_lcdk: fix MMC boot Bartosz Golaszewski
2019-12-02 11:54   ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103165928.GR4866@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox