public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v2] arm: exynos: Use proper PMIC device name
       [not found] <CGME20200115153914eucas1p28ecc7976969fcbc50ac8eb15abe05f22@eucas1p2.samsung.com>
@ 2020-01-15 15:39 ` Marek Szyprowski
  2020-01-15 16:06   ` Lukasz Majewski
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2020-01-15 15:39 UTC (permalink / raw)
  To: u-boot

Since commit 4213609cc7 ("drivers: core: use strcmp when find device by
name") one has to provide full name to get requested object. Fix the code
used to detect enable power regulators on Odroid boards to use proper PMIC
device device name then.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
---
 board/samsung/common/exynos5-dt-types.c | 2 +-
 board/samsung/common/exynos5-dt.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/samsung/common/exynos5-dt-types.c b/board/samsung/common/exynos5-dt-types.c
index d51cc4eedc..31e23e8b07 100644
--- a/board/samsung/common/exynos5-dt-types.c
+++ b/board/samsung/common/exynos5-dt-types.c
@@ -129,7 +129,7 @@ static const char *odroid_get_type_str(void)
 	if (gd->board_type != EXYNOS5_BOARD_ODROID_XU3_REV02)
 		goto exit;
 
-	ret = pmic_get("s2mps11", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 	if (ret)
 		goto exit;
 
diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c
index 87eb381345..c5e77480f5 100644
--- a/board/samsung/common/exynos5-dt.c
+++ b/board/samsung/common/exynos5-dt.c
@@ -64,7 +64,7 @@ int exynos_power_init(void)
 	int ret;
 
 #ifdef CONFIG_PMIC_S2MPS11
-	ret = pmic_get("s2mps11_pmic", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 #else
 	ret = pmic_get("max77686", &dev);
 	if (!ret) {
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH v2] arm: exynos: Use proper PMIC device name
  2020-01-15 15:39 ` [PATCH v2] arm: exynos: Use proper PMIC device name Marek Szyprowski
@ 2020-01-15 16:06   ` Lukasz Majewski
  0 siblings, 0 replies; 2+ messages in thread
From: Lukasz Majewski @ 2020-01-15 16:06 UTC (permalink / raw)
  To: u-boot

On Wed, 15 Jan 2020 16:39:09 +0100
Marek Szyprowski <m.szyprowski@samsung.com> wrote:

> Since commit 4213609cc7 ("drivers: core: use strcmp when find device
> by name") one has to provide full name to get requested object. Fix
> the code used to detect enable power regulators on Odroid boards to
> use proper PMIC device device name then.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  board/samsung/common/exynos5-dt-types.c | 2 +-
>  board/samsung/common/exynos5-dt.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/samsung/common/exynos5-dt-types.c
> b/board/samsung/common/exynos5-dt-types.c index
> d51cc4eedc..31e23e8b07 100644 ---
> a/board/samsung/common/exynos5-dt-types.c +++
> b/board/samsung/common/exynos5-dt-types.c @@ -129,7 +129,7 @@ static
> const char *odroid_get_type_str(void) if (gd->board_type !=
> EXYNOS5_BOARD_ODROID_XU3_REV02) goto exit;
>  
> -	ret = pmic_get("s2mps11", &dev);
> +	ret = pmic_get("s2mps11_pmic at 66", &dev);
>  	if (ret)
>  		goto exit;
>  
> diff --git a/board/samsung/common/exynos5-dt.c
> b/board/samsung/common/exynos5-dt.c index 87eb381345..c5e77480f5
> 100644 --- a/board/samsung/common/exynos5-dt.c
> +++ b/board/samsung/common/exynos5-dt.c
> @@ -64,7 +64,7 @@ int exynos_power_init(void)
>  	int ret;
>  
>  #ifdef CONFIG_PMIC_S2MPS11
> -	ret = pmic_get("s2mps11_pmic", &dev);
> +	ret = pmic_get("s2mps11_pmic at 66", &dev);
>  #else
>  	ret = pmic_get("max77686", &dev);
>  	if (!ret) {

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200115/e8d18b91/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-15 16:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20200115153914eucas1p28ecc7976969fcbc50ac8eb15abe05f22@eucas1p2.samsung.com>
2020-01-15 15:39 ` [PATCH v2] arm: exynos: Use proper PMIC device name Marek Szyprowski
2020-01-15 16:06   ` Lukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox