[PATCH] clk: Fix error checking of dev_read_addr_ptr

[PATCH] clk: Fix error checking of dev_read_addr_ptr

[Sean Anderson]

dev_read_addr_ptr returns NULL on error, not FDT_ADDR_T_NONE.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
 drivers/clk/imx/clk-imx6q.c  | 2 +-
 drivers/clk/imx/clk-imx8mm.c | 2 +-
 drivers/clk/imx/clk-imx8mn.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
index 5ae4781d11..bd0d3e4f47 100644
--- a/drivers/clk/imx/clk-imx6q.c
+++ b/drivers/clk/imx/clk-imx6q.c
@@ -115,7 +115,7 @@ static int imx6q_clk_probe(struct udevice *dev)

 	/* CCM clocks */
 	base = dev_read_addr_ptr(dev);
-	if (base == (void *)FDT_ADDR_T_NONE)
+	if (!base)
 		return -EINVAL;

 	clk_dm(IMX6QDL_CLK_USDHC1_SEL,
diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index a05dac7c7a..fc41a028f6 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -323,7 +323,7 @@ static int imx8mm_clk_probe(struct udevice *dev)
 	       imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));

 	base = dev_read_addr_ptr(dev);
-	if (base == (void *)FDT_ADDR_T_NONE)
+	if (!base)
 		return -EINVAL;

 	clk_dm(IMX8MM_CLK_A53_SRC,
diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 4048cc63cc..eb43971ae6 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -293,7 +293,7 @@ static int imx8mn_clk_probe(struct udevice *dev)
 	       imx_clk_fixed_factor("sys_pll2_1000m", "sys_pll2_out", 1, 1));

 	base = dev_read_addr_ptr(dev);
-	if (base == (void *)FDT_ADDR_T_NONE)
+	if (!base)
 		return -EINVAL;

 	clk_dm(IMX8MN_CLK_A53_SRC,
-- 
2.24.1

[PATCH] clk: Fix error checking of dev_read_addr_ptr

[Sean Anderson]

On 12/24/19 11:57 PM, Sean Anderson wrote:
> dev_read_addr_ptr returns NULL on error, not FDT_ADDR_T_NONE.
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>

*bump*

Lukasz do you have any comments?

[PATCH] clk: Fix error checking of dev_read_addr_ptr

[Lukasz Majewski]

Hi Sean,

> On 12/24/19 11:57 PM, Sean Anderson wrote:
> > dev_read_addr_ptr returns NULL on error, not FDT_ADDR_T_NONE.
> > 
> > Signed-off-by: Sean Anderson <seanga2@gmail.com>  
> 
> *bump*
> 
> Lukasz do you have any comments?

No, I do not have any comments.

I will prepare PR by end of this week. Thanks for the fix.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200116/86633286/attachment.sig>