* [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()
@ 2020-01-16 15:45 Alifer Moraes
2020-01-17 7:47 ` Oliver Graute
2020-01-20 20:17 ` sbabic at denx.de
0 siblings, 2 replies; 3+ messages in thread
From: Alifer Moraes @ 2020-01-16 15:45 UTC (permalink / raw)
To: u-boot
detail_board_ddr_info() is not used anywhere, so simply remove it.
This function is only used by Layerscape, not by i.MX.
This was detected by the following sparse warning:
board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]
Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
---
board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c b/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
index 2f97d5ce96..8bcbcc0e3f 100644
--- a/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
+++ b/board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c
@@ -107,11 +107,6 @@ int board_init(void)
return 0;
}
-void detail_board_ddr_info(void)
-{
- puts("\nDDR ");
-}
-
/*
* Board specific reset that is system reset.
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()
2020-01-16 15:45 [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info() Alifer Moraes
@ 2020-01-17 7:47 ` Oliver Graute
2020-01-20 20:17 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Graute @ 2020-01-17 7:47 UTC (permalink / raw)
To: u-boot
On 16/01/20, Alifer Moraes wrote:
> detail_board_ddr_info() is not used anywhere, so simply remove it.
>
> This function is only used by Layerscape, not by i.MX.
>
> This was detected by the following sparse warning:
>
> board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
> prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]
>
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info()
2020-01-16 15:45 [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info() Alifer Moraes
2020-01-17 7:47 ` Oliver Graute
@ 2020-01-20 20:17 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2020-01-20 20:17 UTC (permalink / raw)
To: u-boot
> detail_board_ddr_info() is not used anywhere, so simply remove it.
> This function is only used by Layerscape, not by i.MX.
> This was detected by the following sparse warning:
> board/advantech/imx8qm_rom7720_a1/imx8qm_rom7720_a1.c:110:6: warning: no previous
> prototype for ‘detail_board_ddr_info’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
> Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-16 15:45 [PATCH 1/5] imx8qm_rom7720_a1: Remove unused function detail_board_ddr_info() Alifer Moraes
2020-01-17 7:47 ` Oliver Graute
2020-01-20 20:17 ` sbabic at denx.de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox