From: Jorge Ramirez-Ortiz, Gmail <jorge.ramirez.ortiz@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] mx7ulp: soc: s_init should only be executed once
Date: Fri, 17 Jan 2020 13:08:44 +0100 [thread overview]
Message-ID: <20200117120844.GA3054@trex> (raw)
In-Reply-To: <CAOMZO5BS=6J_pwNieFoUU4HLp0_YwPrWS-fBhTN3rokeA7zheQ@mail.gmail.com>
On 17/01/20 08:53:03, Fabio Estevam wrote:
> Hi Jorge,
>
> On Fri, Jan 17, 2020 at 6:50 AM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote:
> >
> > On SPL enabled systems, the current s_init code (wdog, clock and ldo
> > init) is executed twice (by SPL and u-boot). This is not necessary and
> > might lead to boot issues (ie, starting PMC1 when it is already running).
> >
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
>
> The target I use to test LDO-enabled mode does not use SPL, so that's
> why I did not notice the problem.
>
> Thanks for the fix:
Hi Favio,
sorry I forgot to mention: this does not fix the issue I see when executing the LDO init code - that still locks when run from SPL or U-Boot.
This commit is just because I noticed that s_init was being called twice (for SPL and U-Boot) and I dont think it makes sense.
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
next prev parent reply other threads:[~2020-01-17 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:50 [PATCH] mx7ulp: soc: s_init should only be executed once Jorge Ramirez-Ortiz
2020-01-17 11:53 ` Fabio Estevam
2020-01-17 12:08 ` Jorge [this message]
2020-01-19 18:52 ` Jorge
2020-01-19 23:23 ` Fabio Estevam
2020-01-20 20:18 ` sbabic at denx.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117120844.GA3054@trex \
--to=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox