From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jorge Ramirez-Ortiz, Gmail Date: Fri, 17 Jan 2020 13:08:44 +0100 Subject: [PATCH] mx7ulp: soc: s_init should only be executed once In-Reply-To: References: <20200117095025.6979-1-jorge@foundries.io> Message-ID: <20200117120844.GA3054@trex> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 17/01/20 08:53:03, Fabio Estevam wrote: > Hi Jorge, > > On Fri, Jan 17, 2020 at 6:50 AM Jorge Ramirez-Ortiz wrote: > > > > On SPL enabled systems, the current s_init code (wdog, clock and ldo > > init) is executed twice (by SPL and u-boot). This is not necessary and > > might lead to boot issues (ie, starting PMC1 when it is already running). > > > > Signed-off-by: Jorge Ramirez-Ortiz > > The target I use to test LDO-enabled mode does not use SPL, so that's > why I did not notice the problem. > > Thanks for the fix: Hi Favio, sorry I forgot to mention: this does not fix the issue I see when executing the LDO init code - that still locks when run from SPL or U-Boot. This commit is just because I noticed that s_init was being called twice (for SPL and U-Boot) and I dont think it makes sense. > > Reviewed-by: Fabio Estevam