From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Sat, 25 Jan 2020 21:18:12 +0100 Subject: [PATCH v2 01/11] clk: Always use the supplied struct clk In-Reply-To: References: <3411d84b-5a56-ae4e-1deb-085ef1a4971d@gmail.com> <752D002CFF5D0F4FA35C0100F1D73F3FA46C88BE@ATCPCS16.andestech.com> <2cea6898-1ce5-f7fe-694e-48d782d306d9@gmail.com> <8c660de0-b462-2a71-2710-dd5dc7cb4852@gmail.com> <20200124152719.10444032@jawa> Message-ID: <20200125211812.36998794@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Sean, > On 1/24/20 9:27 AM, Lukasz Majewski wrote: > > I saw your patches. Unfortunately, there was the Christmas/New > > year's break and afterwards I had some more urgent tasks to do. > > Apologize for that... > > > > What I would like to see here is to reuse (or better - make the code > > less confusing) the code. > > > > Rationale - the CCF was ported from iMX6Q Linux code from the > > outset. > > > > Then Peng (CC'ed) wanted to adjust it to support composite clocks > > from i.MX8. > > > > As a result the CCF drifted to be an iMX aligned, but the goal is to > > have it usable for other archs as well (and reuse from Linux as > > much as possible). > > Ok, so I believe that these patches are a step in that direction. Is > there any specific feedback you would like to give regarding them? > I've tried to infer what good default behaviour should be. However, > I'm sure there are places where someone more familiar with the CCF > would be able to comment on. I will do the review by the end of the weekend. > > --Sean > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: