public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: LABBE Corentin <clabbe@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 0/3] Ethernet support for Raspberry Pi 4
Date: Mon, 27 Jan 2020 11:09:49 +0100	[thread overview]
Message-ID: <20200127100949.GA14303@Red> (raw)
In-Reply-To: <20200127011444.8114-1-andre.przywara@arm.com>

On Mon, Jan 27, 2020 at 01:14:41AM +0000, Andre Przywara wrote:
> This series adds Ethernet support for the Raspberry Pi 4. The SoC
> includes a "Broadcom Genet v5 MAC" IP, connected as a proper platform
> device (no USB anymore!). Patch 1 provides a driver for that. There does
> not seem to be publicly available documentation, so this is based on the
> Linux driver, but stripped down to just provide what U-Boot needs.
> Patch 2 fixes up the RPi4 memory map to accommodate the MMIO area the
> MAC lives in, while patch 3 enables it in the respective defconfigs.
> 
> This version fixes the nasty SError issue that showed when booting Linux.
> To see the changes as patches, refer to [1].
> 
> Please have a look and test it, I hope this helps to simplify
> development, as you spare the SD card and its slot from heavy swapping.
> 
> Cheers,
> Andre.
> 
> [1] https://github.com/apritzel/u-boot/commits/rpi4-eth-v3
> 
> Changelog v2 ... v3:
> - properly reset MAC in eth_probe() to avoid SError in Linux
> - disable RX DMA upon stopping the device
> 
> Changelog v1 ... v2:
> - use native endianess functions when accessing MMIO registers
> - use dev_* DM wrappers for accessing devicetree data
> - round base and length for flush_dcache_range, plus a comment
> - check and round length for invalidate_cache_range
> - support RGMII_RXID PHY mode, to support mainline .dtb
> 
> Amit Singh Tomar (3):
>   net: Add support for Broadcom GENETv5 Ethernet controller
>   rpi4: Update memory map to accommodate scb devices
>   rpi4: Enable GENET Ethernet controller
> 
>  arch/arm/mach-bcm283x/init.c |   6 +-
>  configs/rpi_4_32b_defconfig  |   2 +
>  configs/rpi_4_defconfig      |   2 +
>  configs/rpi_arm64_defconfig  |   1 +
>  drivers/net/Kconfig          |   7 +
>  drivers/net/Makefile         |   1 +
>  drivers/net/bcmgenet.c       | 729 +++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 745 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/net/bcmgenet.c
> 
> -- 

Hello

I have successfully started a kernel (5.5.0-rc7-next-20200124-00075-gd1ea5e663326) with this serie.
Thanks for your help by IRC, updating firmware seems to did the trick.
The kernel panic just after with "OF: reserved mem: failed to allocate memory for node 'linux,cma'" but that's another story.

Tested-by: Corentin Labbe <clabbe@baylibre.com>
Thanks

  parent reply	other threads:[~2020-01-27 10:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  1:14 [PATCH v3 0/3] Ethernet support for Raspberry Pi 4 Andre Przywara
2020-01-27  1:14 ` [PATCH v3 1/3] net: Add support for Broadcom GENETv5 Ethernet controller Andre Przywara
2020-01-27  1:14 ` [PATCH v3 2/3] rpi4: Update memory map to accommodate scb devices Andre Przywara
2020-01-27  1:14 ` [PATCH v3 3/3] rpi4: Enable GENET Ethernet controller Andre Przywara
2020-01-27 10:09 ` LABBE Corentin [this message]
2020-01-27 10:57   ` [PATCH v3 0/3] Ethernet support for Raspberry Pi 4 Amit Tomer
2020-01-27 11:50     ` LABBE Corentin
2020-01-27 12:06       ` Andre Przywara
2020-01-27 13:15         ` LABBE Corentin
2020-01-28 22:21         ` Jaehoon Chung
2020-01-29  8:04           ` Matthias Brugger
2020-02-03  9:48           ` LABBE Corentin
2020-02-17 11:37             ` Jaehoon Chung
2020-02-18  2:13               ` Jaehoon Chung
2020-02-18  9:59                 ` LABBE Corentin
2020-02-03  9:50         ` LABBE Corentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127100949.GA14303@Red \
    --to=clabbe@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox