public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] net: Handle disabling of compilation for SPL builds
Date: Mon, 27 Jan 2020 11:51:24 -0500	[thread overview]
Message-ID: <20200127165124.GS9259@bill-the-cat> (raw)
In-Reply-To: <20200127124017.417345-1-nathan@nathanrossi.com>

On Mon, Jan 27, 2020 at 12:40:17PM +0000, Nathan Rossi wrote:

> Whilst the net/ directory is excluded from libs-y when
> CONFIG_SPL_NET_SUPPORT is disabled, this does not prevent SPL builds
> trying to compile net/ objects. During SPL builds overwrite the value of
> CONFIG_NET with CONFIG_SPL_NET_SUPPORT to exclude compilation during SPL
> builds.
> 
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
>  net/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/Makefile b/net/Makefile
> index fef71b940a..0f57244015 100644
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -5,6 +5,10 @@
>  
>  #ccflags-y += -DDEBUG
>  
> +ifdef CONFIG_SPL_BUILD
> +CONFIG_NET = $(CONFIG_SPL_NET_SUPPORT)
> +endif
> +
>  obj-$(CONFIG_NET)      += arp.o
>  obj-$(CONFIG_CMD_BOOTP) += bootp.o
>  obj-$(CONFIG_CMD_CDP)  += cdp.o

This needs to be fixed the same way we have in other cases and that is
for CONFIG_SPL_NET_SUPPORT to become CONFIG_SPL_NET and then Makefiles
use 'obj-$(CONFIG_$(SPL_)NET) += ...' and so forth.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200127/fbd55d6a/attachment.sig>

  reply	other threads:[~2020-01-27 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 12:40 [PATCH] net: Handle disabling of compilation for SPL builds Nathan Rossi
2020-01-27 16:51 ` Tom Rini [this message]
2020-01-28  7:51   ` Nathan Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127165124.GS9259@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox