public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 12/21] pinctrl: add i.MXRT driver
Date: Tue, 28 Jan 2020 09:27:22 +0100	[thread overview]
Message-ID: <20200128092722.5db34dc2@jawa> (raw)
In-Reply-To: <20200110144711.81938-13-giulio.benetti@benettiengineering.com>

Hi Giulio,

> Add i.MXRT pinctrl driver.

Please add information from where this code was ported (SHA1, branch,
commit name).

Nit tip:

- Please use patman, which will give you a warning if somethinf with
  the commit or commit message is broken.

> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  drivers/pinctrl/nxp/Kconfig         | 14 ++++++++++
>  drivers/pinctrl/nxp/Makefile        |  1 +
>  drivers/pinctrl/nxp/pinctrl-imxrt.c | 40
> +++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+)
>  create mode 100644 drivers/pinctrl/nxp/pinctrl-imxrt.c
> 
> diff --git a/drivers/pinctrl/nxp/Kconfig b/drivers/pinctrl/nxp/Kconfig
> index f2e67ca231..ec55351e61 100644
> --- a/drivers/pinctrl/nxp/Kconfig
> +++ b/drivers/pinctrl/nxp/Kconfig
> @@ -99,6 +99,20 @@ config PINCTRL_MXS
>  	  familiy, e.g. i.MX28. This feature depends on device tree
>  	  configuration.
>  
> +config PINCTRL_IMXRT
> +	bool "IMXRT pinctrl driver"
> +	depends on ARCH_IMXRT && PINCTRL_FULL
> +	select DEVRES
> +	select PINCTRL_IMX
> +	help
> +	  Say Y here to enable the imxrt pinctrl driver
> +
> +	  This provides a simple pinctrl driver for i.MXRT SoC
> familiy.
> +	  This feature depends on device tree configuration. This
> driver
> +	  is different from the linux one, this is a simple
> implementation,
> +	  only parses the 'fsl,pins' property and configure related
> +	  registers.
> +
>  config PINCTRL_VYBRID
>  	bool "Vybrid (vf610) pinctrl driver"
>  	depends on ARCH_VF610 && PINCTRL_FULL
> diff --git a/drivers/pinctrl/nxp/Makefile
> b/drivers/pinctrl/nxp/Makefile index b86448aac9..066ca75b65 100644
> --- a/drivers/pinctrl/nxp/Makefile
> +++ b/drivers/pinctrl/nxp/Makefile
> @@ -8,3 +8,4 @@ obj-$(CONFIG_PINCTRL_IMX8)		+=
> pinctrl-imx8.o obj-$(CONFIG_PINCTRL_IMX8M)		+=
> pinctrl-imx8m.o obj-$(CONFIG_PINCTRL_MXS)		+=
> pinctrl-mxs.o obj-$(CONFIG_PINCTRL_VYBRID)		+=
> pinctrl-vf610.o +obj-$(CONFIG_PINCTRL_IMXRT)		+=
> pinctrl-imxrt.o diff --git a/drivers/pinctrl/nxp/pinctrl-imxrt.c
> b/drivers/pinctrl/nxp/pinctrl-imxrt.c new file mode 100644
> index 0000000000..4a93941927
> --- /dev/null
> +++ b/drivers/pinctrl/nxp/pinctrl-imxrt.c
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019
> + * Author(s): Giulio Benetti <giulio.benetti@benettiengineering.com>
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <dm/pinctrl.h>
> +
> +#include "pinctrl-imx.h"
> +
> +static struct imx_pinctrl_soc_info imxrt_pinctrl_soc_info = {
> +	.flags = ZERO_OFFSET_VALID,
> +};
> +
> +static int imxrt_pinctrl_probe(struct udevice *dev)
> +{
> +	struct imx_pinctrl_soc_info *info =
> +		(struct imx_pinctrl_soc_info
> *)dev_get_driver_data(dev); +
> +	return imx_pinctrl_probe(dev, info);
> +}
> +
> +static const struct udevice_id imxrt_pinctrl_match[] = {
> +	{ .compatible = "fsl,imxrt-iomuxc",
> +	  .data = (ulong)&imxrt_pinctrl_soc_info },
> +	{ /* sentinel */ }
> +};
> +
> +U_BOOT_DRIVER(imxrt_pinctrl) = {
> +	.name = "imxrt-pinctrl",
> +	.id = UCLASS_PINCTRL,
> +	.of_match = of_match_ptr(imxrt_pinctrl_match),
> +	.probe = imxrt_pinctrl_probe,
> +	.remove = imx_pinctrl_remove,
> +	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
> +	.ops = &imx_pinctrl_ops,
> +	.flags = DM_FLAG_PRE_RELOC,
> +};

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200128/81b0b907/attachment.sig>

  parent reply	other threads:[~2020-01-28  8:27 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 14:46 [PATCH v2 00/21] Add i.MXRT family support Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 01/21] spl: fix entry_point equal to load_addr Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:09   ` Lukasz Majewski
2020-01-28 16:37     ` Giulio Benetti
2020-01-29  8:33       ` Lukasz Majewski
2020-01-10 14:46 ` [PATCH v2 02/21] armv7m: cache: add mmu_set_region_dcache_behaviour() stub for compatibility Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:10   ` Lukasz Majewski
2020-01-28 16:50     ` Giulio Benetti
2020-01-29  8:36       ` Lukasz Majewski
2020-01-10 14:46 ` [PATCH v2 03/21] clk: imx: pllv3: register PLLV3 GENERIC and USB as 2 different clocks Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 04/21] clk: imx: pllv3: set div_mask differently if PLLV3 is GENERIC or USB Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 05/21] clk: imx: pllv3: add enable() support Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:14   ` Lukasz Majewski
2020-01-28 18:46     ` Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 06/21] clk: imx: pllv3: add disable() support Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 07/21] clk: imx: pllv3: add set_rate() support Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 08/21] clk: imx: pllv3: add PLLV3_SYS support Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 09/21] clk: imx: pllv3: add support for PLLV3_AV type Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:20   ` Lukasz Majewski
2020-01-31 13:50     ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 10/21] clk: imx: pfd: add set_rate() Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-10 14:47 ` [PATCH v2 11/21] clk: imx: add i.IMXRT1050 clk driver Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:23   ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 12/21] pinctrl: add i.MXRT driver Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-28  8:27   ` Lukasz Majewski [this message]
2020-01-10 14:47 ` [PATCH v2 13/21] gpio: mxc_gpio: add support for i.MXRT1050 Giulio Benetti
2020-01-15 12:46   ` sbabic at denx.de
2020-01-28  8:27   ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 14/21] ARM: dts: imxrt1050: add dtsi file Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-28  8:31   ` Lukasz Majewski
2020-01-28 18:48     ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 15/21] serial_lpuart: add clock enable if CONFIG_CLK is defined Giulio Benetti
2020-01-15 12:47   ` sbabic at denx.de
2020-01-28  8:36   ` Lukasz Majewski
2020-01-28 18:49     ` Giulio Benetti
2020-01-31 13:39       ` [PATCH] serial_lpuart: make clock failure less verbose Giulio Benetti
2020-01-31 18:14         ` Simon Glass
2020-01-31 20:24           ` Giulio Benetti
2020-02-01 12:48             ` Lukasz Majewski
2020-02-10 22:17               ` Giulio Benetti
2020-03-10 15:31         ` sbabic at denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128092722.5db34dc2@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox