From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 01/21] spl: fix entry_point equal to load_addr
Date: Wed, 29 Jan 2020 09:33:29 +0100 [thread overview]
Message-ID: <20200129093329.71c245e8@jawa> (raw)
In-Reply-To: <5f587fb7-c588-657c-046a-bb352f9bc409@benettiengineering.com>
On Tue, 28 Jan 2020 17:37:17 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Hi Lukasz,
>
> all patch series has already been applied, anyway I answer to your
> suggestions since something was missing and I'm going to create a
> patch for that.
>
> So...
>
> On 1/28/20 9:09 AM, Lukasz Majewski wrote:
> > Hi Giulio,
> >
> >> At the moment entry_point is set to image_get_load(header) that
> >> sets it to "load address" instead of "entry point", assuming
> >> entry_point is equal to load_addr, but it's not true. Then
> >> load_addr is set to "entry_point - header_size", but this is wrong
> >> too since load_addr is not an entry point.
> >>
> >> So use image_get_ep() for entry_point assignment and
> >> image_get_load() for load_addr assignment.
> >>
> >> Signed-off-by: Giulio Benetti
> >> <giulio.benetti@benettiengineering.com> ---
> >> common/spl/spl.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/common/spl/spl.c b/common/spl/spl.c
> >> index c1fce62b91..19085ad270 100644
> >> --- a/common/spl/spl.c
> >> +++ b/common/spl/spl.c
> >> @@ -284,9 +284,9 @@ int spl_parse_image_header(struct
> >> spl_image_info *spl_image, spl_image->entry_point =
> >> image_get_ep(header); spl_image->size =
> >> image_get_data_size(header); } else {
> >> - spl_image->entry_point =
> >> image_get_load(header);
> >> + spl_image->entry_point =
> >> image_get_ep(header); /* Load including the header */
> >> - spl_image->load_addr =
> >> spl_image->entry_point -
> >> + spl_image->load_addr =
> >> image_get_load(header) - header_size;
> >> spl_image->size =
> >> image_get_data_size(header) + header_size;
> >
> > I'm concerned, that this change will silently break several boards -
> > the problem is with assumption that entry point is equal to
> > load_addr.
> >
> > It would be best to pull this change ASAP, so we would have a
> > chance to fix this by next release.
>
> It's been committed after Patrice fixed a lot of boards:
> https://gitlab.denx.de/u-boot/u-boot/commit/38a6cce65737096b836d43a22f09b7a54c9d020c
> and
> https://gitlab.denx.de/u-boot/u-boot/commit/74bb4570a952b06fecfafc5b961a5cb5147ec544
>
> Indeed at the first moment it's been committed by Tom Rini and
> started to cause boot failure as you were worried for, then it's been
> reverted, then it's been re-applied after applying Patrice series.
>
Ach... Ok. No problem then.
> Best regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/dad41610/attachment.sig>
next prev parent reply other threads:[~2020-01-29 8:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:46 [PATCH v2 00/21] Add i.MXRT family support Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 01/21] spl: fix entry_point equal to load_addr Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:09 ` Lukasz Majewski
2020-01-28 16:37 ` Giulio Benetti
2020-01-29 8:33 ` Lukasz Majewski [this message]
2020-01-10 14:46 ` [PATCH v2 02/21] armv7m: cache: add mmu_set_region_dcache_behaviour() stub for compatibility Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:10 ` Lukasz Majewski
2020-01-28 16:50 ` Giulio Benetti
2020-01-29 8:36 ` Lukasz Majewski
2020-01-10 14:46 ` [PATCH v2 03/21] clk: imx: pllv3: register PLLV3 GENERIC and USB as 2 different clocks Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 04/21] clk: imx: pllv3: set div_mask differently if PLLV3 is GENERIC or USB Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 05/21] clk: imx: pllv3: add enable() support Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:14 ` Lukasz Majewski
2020-01-28 18:46 ` Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 06/21] clk: imx: pllv3: add disable() support Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 07/21] clk: imx: pllv3: add set_rate() support Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 08/21] clk: imx: pllv3: add PLLV3_SYS support Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 09/21] clk: imx: pllv3: add support for PLLV3_AV type Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:20 ` Lukasz Majewski
2020-01-31 13:50 ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 10/21] clk: imx: pfd: add set_rate() Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-10 14:47 ` [PATCH v2 11/21] clk: imx: add i.IMXRT1050 clk driver Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:23 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 12/21] pinctrl: add i.MXRT driver Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:27 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 13/21] gpio: mxc_gpio: add support for i.MXRT1050 Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:27 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 14/21] ARM: dts: imxrt1050: add dtsi file Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:31 ` Lukasz Majewski
2020-01-28 18:48 ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 15/21] serial_lpuart: add clock enable if CONFIG_CLK is defined Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:36 ` Lukasz Majewski
2020-01-28 18:49 ` Giulio Benetti
2020-01-31 13:39 ` [PATCH] serial_lpuart: make clock failure less verbose Giulio Benetti
2020-01-31 18:14 ` Simon Glass
2020-01-31 20:24 ` Giulio Benetti
2020-02-01 12:48 ` Lukasz Majewski
2020-02-10 22:17 ` Giulio Benetti
2020-03-10 15:31 ` sbabic at denx.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129093329.71c245e8@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox