From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 02/21] armv7m: cache: add mmu_set_region_dcache_behaviour() stub for compatibility
Date: Wed, 29 Jan 2020 09:36:18 +0100 [thread overview]
Message-ID: <20200129093618.638a54d1@jawa> (raw)
In-Reply-To: <41c9ce78-7449-b609-53b5-107e73c7c32f@benettiengineering.com>
On Tue, 28 Jan 2020 17:50:03 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> On 1/28/20 9:10 AM, Lukasz Majewski wrote:
> > Hi Giulio,
> >
> >> Since some driver
> >
> > I would prefer more verbose commit message. Please share which
> > driver requires this change.
>
> Yes, you were right, this is a quite dumb commit log.
>
> Now commit log can't be changed, anyway this is the list of drivers
> that use it:
> drivers/video/mvebu_lcd.c
> drivers/video/mxsfb.c (that I'm going to use soon)
> drivers/video/bcm2835.c
> drivers/video/fsl_dcu_fb.c
> drivers/video/tegra.c
> drivers/video/imx/mxc_ipuv3_fb.c
>
> drivers/net/zynq_gem.c
> drivers/net/mvneta.c
> drivers/net/mvpp2.c
>
> And this function prototype is provided by
> arch/arm/include/asm/system.h
>
> Everything came out when I've tried to build mxsfb.c.
>
> But after this e-mail I've dug deeper and see that sometimes
> mmu_set_region_dcache_behaviour() call is guarded by
> CONFIG_IS_ENABLED(SYS_DCACHE_OFF) and sometimes i.e.
> arch/arm/cpu/armv8/cache_v8.c that function is defined both
> implemented and empty according to CONFIG_IS_ENABLED(SYS_DCACHE_OFF).
> So one chance is to put a check to guard against
> CONFIG_IS_ENABLED(SYS_DCACHE_OFF) on every call(the files listed
> above), otherwise, where is guarded we should remove the guard and
> adding missing mmu_set_region_dcache_behaviour() empty
> implementation. ~5 files to touch, but if you say it's worth, I can
> do patches for that, and I don't see any drawbacks expect having a
> standard way on dealing with the cache function.
>
> What about that?
IMHO, it would be best to to this change when you decide to add support
for DCACHE/ICACHE on this SoC.
>
> Kind regards
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/ebd39903/attachment.sig>
next prev parent reply other threads:[~2020-01-29 8:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:46 [PATCH v2 00/21] Add i.MXRT family support Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 01/21] spl: fix entry_point equal to load_addr Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:09 ` Lukasz Majewski
2020-01-28 16:37 ` Giulio Benetti
2020-01-29 8:33 ` Lukasz Majewski
2020-01-10 14:46 ` [PATCH v2 02/21] armv7m: cache: add mmu_set_region_dcache_behaviour() stub for compatibility Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:10 ` Lukasz Majewski
2020-01-28 16:50 ` Giulio Benetti
2020-01-29 8:36 ` Lukasz Majewski [this message]
2020-01-10 14:46 ` [PATCH v2 03/21] clk: imx: pllv3: register PLLV3 GENERIC and USB as 2 different clocks Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 04/21] clk: imx: pllv3: set div_mask differently if PLLV3 is GENERIC or USB Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 05/21] clk: imx: pllv3: add enable() support Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:14 ` Lukasz Majewski
2020-01-28 18:46 ` Giulio Benetti
2020-01-10 14:46 ` [PATCH v2 06/21] clk: imx: pllv3: add disable() support Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 07/21] clk: imx: pllv3: add set_rate() support Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 08/21] clk: imx: pllv3: add PLLV3_SYS support Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-10 14:46 ` [PATCH v2 09/21] clk: imx: pllv3: add support for PLLV3_AV type Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:20 ` Lukasz Majewski
2020-01-31 13:50 ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 10/21] clk: imx: pfd: add set_rate() Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-10 14:47 ` [PATCH v2 11/21] clk: imx: add i.IMXRT1050 clk driver Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:23 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 12/21] pinctrl: add i.MXRT driver Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:27 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 13/21] gpio: mxc_gpio: add support for i.MXRT1050 Giulio Benetti
2020-01-15 12:46 ` sbabic at denx.de
2020-01-28 8:27 ` Lukasz Majewski
2020-01-10 14:47 ` [PATCH v2 14/21] ARM: dts: imxrt1050: add dtsi file Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:31 ` Lukasz Majewski
2020-01-28 18:48 ` Giulio Benetti
2020-01-10 14:47 ` [PATCH v2 15/21] serial_lpuart: add clock enable if CONFIG_CLK is defined Giulio Benetti
2020-01-15 12:47 ` sbabic at denx.de
2020-01-28 8:36 ` Lukasz Majewski
2020-01-28 18:49 ` Giulio Benetti
2020-01-31 13:39 ` [PATCH] serial_lpuart: make clock failure less verbose Giulio Benetti
2020-01-31 18:14 ` Simon Glass
2020-01-31 20:24 ` Giulio Benetti
2020-02-01 12:48 ` Lukasz Majewski
2020-02-10 22:17 ` Giulio Benetti
2020-03-10 15:31 ` sbabic at denx.de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129093618.638a54d1@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox