From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 30 Jan 2020 21:40:24 +0100
Subject: [U-Boot] [PATCH v2 3/3] env: Provide programmatic equivalent to
 'setenv -f'
In-Reply-To: <0102016e8e614227-a8c99a21-6a99-4611-b510-a723bc021b52-000000@eu-west-1.amazonses.com>
References: <20191121143240.122610-1-james.byrne@origamienergy.com>
 <0102016e8e614227-a8c99a21-6a99-4611-b510-a723bc021b52-000000@eu-west-1.amazonses.com>
Message-ID: <20200130204024.646A424065D@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear James,

In message <0102016e8e614227-a8c99a21-6a99-4611-b510-a723bc021b52-000000@eu-west-1.amazonses.com> you wrote:
> Add env_force_set() to provide an equivalent to 'setenv -f' that can be
> used programmatically.

env_set_forced() ?

> -int env_set(const char *varname, const char *varvalue)
> +static int do_programmatic_env_set(const char *varname, const char *varvalue,
> +				   int env_flag)
>  {
>  	/* before import into hashtable */
>  	if (!(gd->flags & GD_FLG_ENV_READY))
>  		return 1;
>  
>  	if (!varvalue || varvalue[0] == '\0')
> -		return do_env_remove(varname, H_PROGRAMMATIC);
> +		return do_env_remove(varname, H_PROGRAMMATIC | env_flag);
> +
> +	return do_env_update(varname, varvalue, H_PROGRAMMATIC | env_flag);
> +}
> +
> +int env_set(const char *varname, const char *varvalue)
> +{
> +	return do_programmatic_env_set(varname, varvalue, 0);
> +}
>  
> -	return do_env_update(varname, varvalue, H_PROGRAMMATIC);
> +int env_force_set(const char *varname, const char *varvalue)
> +{
> +	return do_programmatic_env_set(varname, varvalue, H_FORCE);
>  }

You add another level of function nesting and add more lines of code
than if just coppying the 3 C statements.

If possible, please also try not to come up with so awfully long
names like do_programmatic_env_set() - hey, this is allprogrammatic
what we're coding here, isn;t it?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The goal of science is to build better mousetraps. The goal of nature
is to build better mice.