[PATCH] cmd: Handle CONFIG_(SPL_)ENV_SUPPORT for toggling the nvedit object

[PATCH] cmd: Handle CONFIG_(SPL_)ENV_SUPPORT for toggling the nvedit object

[Nathan Rossi]

When CONFIG_SPL_ENV_SUPPORT is disabled, nvedit was still being included
as part of the build. Use the CONFIG_SPL_ENV_SUPPORT value as well as
the non SPL CONFIG_ENV_SUPPORT variable to enable/disable the inclusion
of nvedit.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
---
 cmd/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/Makefile b/cmd/Makefile
index 4f29b72c69..90dc09d095 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -186,7 +186,7 @@ endif # !CONFIG_SPL_BUILD
 obj-$(CONFIG_$(SPL_)CMD_TLV_EEPROM) += tlv_eeprom.o
 
 # core command
-obj-y += nvedit.o
+obj-$(CONFIG_$(SPL_)ENV_SUPPORT) += nvedit.o
 
 obj-$(CONFIG_TI_COMMON_CMD_OPTIONS) += ti/
 
---
2.24.1

[PATCH] cmd: Handle CONFIG_(SPL_)ENV_SUPPORT for toggling the nvedit object

[Tom Rini]

On Mon, Jan 27, 2020 at 08:04:53AM +0000, Nathan Rossi wrote:

> When CONFIG_SPL_ENV_SUPPORT is disabled, nvedit was still being included
> as part of the build. Use the CONFIG_SPL_ENV_SUPPORT value as well as
> the non SPL CONFIG_ENV_SUPPORT variable to enable/disable the inclusion
> of nvedit.
> 
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>

This breaks a number of platforms such as P1010RDB-PB_NAND please
address and resubmit, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200201/3c9a34b3/attachment.sig>