* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
@ 2020-01-31 13:56 Oliver Graute
2020-02-03 15:13 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-01-31 13:56 UTC (permalink / raw)
To: u-boot
This fix the following issue on the imx8qm_rom7720 board:
Booting from net ...
Could not get PHY for FEC0: addr 0
Could not get PHY for FEC0: addr 0
Could not get PHY for FEC0: addr 0
Could not get PHY for FEC0: addr 0
Can't find FEC0 clk rate: -19
This fix is necessary because of the changes introduced by commit:
1f60789602e0d5f5f9a8b507f25737c65b5d8daa.
Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Ye Li <ye.li@nxp.com>
Cc: uboot-imx <uboot-imx@nxp.com>
---
include/configs/imx8qm_rom7720.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h
index 865863eb7c..d503ddbffe 100644
--- a/include/configs/imx8qm_rom7720.h
+++ b/include/configs/imx8qm_rom7720.h
@@ -171,6 +171,7 @@
/* Networking */
#define CONFIG_FEC_XCV_TYPE RGMII
+#define CONFIG_FEC_MXC_PHYADDR -1
#define FEC_QUIRK_ENET_MAC
#endif /* __IMX8QM_ROM7720_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
2020-01-31 13:56 [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1 Oliver Graute
@ 2020-02-03 15:13 ` Fabio Estevam
2020-02-03 15:31 ` Oliver Graute
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2020-02-03 15:13 UTC (permalink / raw)
To: u-boot
On Fri, Jan 31, 2020 at 10:56 AM Oliver Graute
<oliver.graute@kococonnector.com> wrote:
>
> This fix the following issue on the imx8qm_rom7720 board:
>
> Booting from net ...
> Could not get PHY for FEC0: addr 0
> Could not get PHY for FEC0: addr 0
> Could not get PHY for FEC0: addr 0
> Could not get PHY for FEC0: addr 0
> Can't find FEC0 clk rate: -19
>
> This fix is necessary because of the changes introduced by commit:
>
> 1f60789602e0d5f5f9a8b507f25737c65b5d8daa.
>
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Ye Li <ye.li@nxp.com>
> Cc: uboot-imx <uboot-imx@nxp.com>
> ---
> include/configs/imx8qm_rom7720.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h
> index 865863eb7c..d503ddbffe 100644
> --- a/include/configs/imx8qm_rom7720.h
> +++ b/include/configs/imx8qm_rom7720.h
> @@ -171,6 +171,7 @@
>
> /* Networking */
> #define CONFIG_FEC_XCV_TYPE RGMII
> +#define CONFIG_FEC_MXC_PHYADDR -1
Shouldn't the Ethernet PHY address be retrieved from the device tree instead?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
2020-02-03 15:13 ` Fabio Estevam
@ 2020-02-03 15:31 ` Oliver Graute
2020-02-03 15:39 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-02-03 15:31 UTC (permalink / raw)
To: u-boot
On 03/02/20, Fabio Estevam wrote:
> On Fri, Jan 31, 2020 at 10:56 AM Oliver Graute
> <oliver.graute@kococonnector.com> wrote:
> >
> > This fix the following issue on the imx8qm_rom7720 board:
> >
> > Booting from net ...
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Can't find FEC0 clk rate: -19
> >
> > This fix is necessary because of the changes introduced by commit:
> >
> > 1f60789602e0d5f5f9a8b507f25737c65b5d8daa.
> >
> > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Peng Fan <peng.fan@nxp.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Ye Li <ye.li@nxp.com>
> > Cc: uboot-imx <uboot-imx@nxp.com>
> > ---
> > include/configs/imx8qm_rom7720.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h
> > index 865863eb7c..d503ddbffe 100644
> > --- a/include/configs/imx8qm_rom7720.h
> > +++ b/include/configs/imx8qm_rom7720.h
> > @@ -171,6 +171,7 @@
> >
> > /* Networking */
> > #define CONFIG_FEC_XCV_TYPE RGMII
> > +#define CONFIG_FEC_MXC_PHYADDR -1
>
> Shouldn't the Ethernet PHY address be retrieved from the device tree instead?
Yes, but phy addr 0 is currently not working that way for me. So I tried
to solve it by autodetecting the phy. Please see this thread:
https://lists.denx.de/pipermail/u-boot/2019-December/393969.html
Best Regards,
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
2020-02-03 15:31 ` Oliver Graute
@ 2020-02-03 15:39 ` Fabio Estevam
2020-02-03 16:07 ` Oliver Graute
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2020-02-03 15:39 UTC (permalink / raw)
To: u-boot
On Mon, Feb 3, 2020 at 12:33 PM Oliver Graute <oliver.graute@gmail.com> wrote:
> Yes, but phy addr 0 is currently not working that way for me. So I tried
> to solve it by autodetecting the phy. Please see this thread:
Looking at your other patch, it looks like you have:
+ ethphy0: ethernet-phy at 0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <6>;
+ at803x,eee-disabled;
+ at803x,vddio-1p8v;
+ };
which shows a mismatch between the @0 and the reg field. Building with
W=1 should have warned you about that.
So it seems you need to fix your dts.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
2020-02-03 15:39 ` Fabio Estevam
@ 2020-02-03 16:07 ` Oliver Graute
2020-02-05 0:49 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Graute @ 2020-02-03 16:07 UTC (permalink / raw)
To: u-boot
On 03/02/20, Fabio Estevam wrote:
> On Mon, Feb 3, 2020 at 12:33 PM Oliver Graute <oliver.graute@gmail.com> wrote:
>
> > Yes, but phy addr 0 is currently not working that way for me. So I tried
> > to solve it by autodetecting the phy. Please see this thread:
>
> Looking at your other patch, it looks like you have:
>
> + ethphy0: ethernet-phy at 0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <6>;
> + at803x,eee-disabled;
> + at803x,vddio-1p8v;
> + };
>
> which shows a mismatch between the @0 and the reg field. Building with
> W=1 should have warned you about that.
>
> So it seems you need to fix your dts.
thx, I'll fix that on the congatec cgtqmx8 board dts file. The phy issue here
was on the advantech imx8qm-rom7720 board.
Best regards,
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
2020-02-03 16:07 ` Oliver Graute
@ 2020-02-05 0:49 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2020-02-05 0:49 UTC (permalink / raw)
To: u-boot
Hi Oliver,
On Mon, Feb 3, 2020 at 1:09 PM Oliver Graute <oliver.graute@gmail.com> wrote:
> thx, I'll fix that on the congatec cgtqmx8 board dts file. The phy issue here
> was on the advantech imx8qm-rom7720 board.
imx8qm-rom7720-a1.dts seems to properly describe the PHY addresses.
I haven't followed the whole discussion you pointed out earlier, but
it seems to my that setting:
#define CONFIG_FEC_MXC_PHYADDR -1
goes in the opposite direction of moving things to DM as we have a way
to pass the PHY address via devicetree.
Tom, Joe? Any comments?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-05 0:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-31 13:56 [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1 Oliver Graute
2020-02-03 15:13 ` Fabio Estevam
2020-02-03 15:31 ` Oliver Graute
2020-02-03 15:39 ` Fabio Estevam
2020-02-03 16:07 ` Oliver Graute
2020-02-05 0:49 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox