U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] ARM: keystone2: enable initrd fixup for LPAE addressing
Date: Tue, 11 Feb 2020 10:01:30 -0500	[thread overview]
Message-ID: <20200211150130.GE13379@bill-the-cat> (raw)
In-Reply-To: <20200211035552.5686-1-lokeshvutla@ti.com>

On Tue, Feb 11, 2020 at 09:25:52AM +0530, Lokesh Vutla wrote:

> From: Tero Kristo <t-kristo@ti.com>
> 
> Keystone2 u-boot loads the initrd image into non-LPAE addressed memory
> but linux kernel is running in LPAE. This causes a conflict as kernel
> detects that non-memory address is passed and kernel ignores initrd.
> There is an existing fixup logic to modify the address in the proper
> configuration, but this is disabled at the moment. Enable the fixup
> by setting the env variable for this so that initrd can be used
> properly.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> - This fixes boot on k2g platforms.
> 
>  include/configs/ti_armv7_keystone2.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
> index ba12428dbe..1b014c1022 100644
> --- a/include/configs/ti_armv7_keystone2.h
> +++ b/include/configs/ti_armv7_keystone2.h
> @@ -213,6 +213,7 @@
>  	"tftp_root=/\0"							\
>  	"nfs_root=/export\0"						\
>  	"mem_lpae=1\0"							\
> +	"uinitrd_fixup=1\0"						\
>  	"addr_ubi=0x82000000\0"						\
>  	"addr_secdb_key=0xc000000\0"					\
>  	"name_kern=zImage\0"						\

OK, hold up.  Why is any of this code needed and can't the normal
bootm_size / bootm_low / etc as documented in the README enforce these
constraints?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200211/c7c29fe8/attachment.sig>

  reply	other threads:[~2020-02-11 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  3:55 [PATCH] ARM: keystone2: enable initrd fixup for LPAE addressing Lokesh Vutla
2020-02-11 15:01 ` Tom Rini [this message]
2020-02-12  4:07   ` Lokesh Vutla
2020-02-12 13:04     ` Tom Rini
2020-02-14  9:52 ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211150130.GE13379@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox