* [PATCH] am335x: evm: defconfig: disable spl tiny printf
@ 2020-02-13 13:34 moseschristopherb at gmail.com
2020-02-17 3:46 ` Lokesh Vutla
0 siblings, 1 reply; 3+ messages in thread
From: moseschristopherb at gmail.com @ 2020-02-13 13:34 UTC (permalink / raw)
To: u-boot
From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
- As tiny printf lib is further optimized, the ability to deal with
ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
we need to disable tiny printf.
- Tested on Beagle Bone Black
Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
---
configs/am335x_evm_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
index 335aa8cfa1..e3fbe2e5bc 100644
--- a/configs/am335x_evm_defconfig
+++ b/configs/am335x_evm_defconfig
@@ -77,6 +77,7 @@ CONFIG_USB_ETHER=y
CONFIG_WDT=y
# CONFIG_SPL_WDT is not set
CONFIG_DYNAMIC_CRC_TABLE=y
+# CONFIG_SPL_USE_TINY_PRINTF is not set
CONFIG_RSA=y
CONFIG_LZO=y
# CONFIG_OF_LIBFDT_OVERLAY is not set
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] am335x: evm: defconfig: disable spl tiny printf
2020-02-13 13:34 [PATCH] am335x: evm: defconfig: disable spl tiny printf moseschristopherb at gmail.com
@ 2020-02-17 3:46 ` Lokesh Vutla
2020-02-18 4:58 ` Vignesh Raghavendra
0 siblings, 1 reply; 3+ messages in thread
From: Lokesh Vutla @ 2020-02-17 3:46 UTC (permalink / raw)
To: u-boot
On 13/02/20 7:04 PM, moseschristopherb at gmail.com wrote:
> From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
>
> - As tiny printf lib is further optimized, the ability to deal with
> ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
> we need to disable tiny printf.
>
> - Tested on Beagle Bone Black
>
> Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
This significantly increases the code size. Did you check how much is increased?
SPL_TINY PRINTF is enabled on am335x_evm_defconfig to reduce the code size.
Wondering what allowed to be built even after disabling tiny printf.
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] am335x: evm: defconfig: disable spl tiny printf
2020-02-17 3:46 ` Lokesh Vutla
@ 2020-02-18 4:58 ` Vignesh Raghavendra
0 siblings, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2020-02-18 4:58 UTC (permalink / raw)
To: u-boot
On 17/02/20 9:16 am, Lokesh Vutla wrote:
>
>
> On 13/02/20 7:04 PM, moseschristopherb at gmail.com wrote:
>> From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
>>
>> - As tiny printf lib is further optimized, the ability to deal with
>> ethaddr is lost. Hence, in order to handle usb-eth boot from SPL
>> we need to disable tiny printf.
>>
>> - Tested on Beagle Bone Black
>>
>> Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
>
> This significantly increases the code size. Did you check how much is increased?
> SPL_TINY PRINTF is enabled on am335x_evm_defconfig to reduce the code size.
> Wondering what allowed to be built even after disabling tiny printf.
>
I agree with Lokesh. Fix should be to revert the change that broke tiny
printf as its breaks an already supported feature. Disabling
SPL_TINY_PRINTF bloats AM335x SPL image size which is already at limit.
Regards
Vignesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-18 4:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-13 13:34 [PATCH] am335x: evm: defconfig: disable spl tiny printf moseschristopherb at gmail.com
2020-02-17 3:46 ` Lokesh Vutla
2020-02-18 4:58 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox