public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: sandbox: CONFIG_SYS_RELOC_GD_ENV_ADDR?
Date: Fri, 14 Feb 2020 10:39:37 +0900	[thread overview]
Message-ID: <20200214013935.GA22953@linaro.org> (raw)

Tom, Simon,

Is CONFIG_SYS_RELOC_GD_ENV_ADDR really needed on sandbox?

When I try to have a variable environment on emulated SPI flash,
the U-Boot binary always crashes: (NOTE: assuming CONFIG_ENV_ADDR == 0)
    $ dd if=/dev/zero of=./spi.bin bs=1M count=4
    $ u-boot -T
    U-Boot 2020.04-rc2-00015-gc9afef2b1938-dirty (Feb 14 2020 - 10:24:59 +0900)

    Model: sandbox
    DRAM:  128 MiB
    WDT:   Started with servicing (60s timeout)
    MMC:   mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD)
    Loading Environment from SPI Flash... SF: Detected m25p16 with page size 256 Bytes, erase size 64 KiB, total 2 MiB
    *** Warning - bad CRC, using default environment

    Segmentation fault (core dumped)

If this configuration is disabled, panic doesn't happen.
I think that it should be turned off in any sandbox*_defconfig.

In addition, please update
- doc/arch/sandbox.rst
- doc/SPI/README.sandbox-spi
Both two still mention already-removed command line option, --spi_sf.
It is confusing.

Thanks,
-Takahiro Akashi

             reply	other threads:[~2020-02-14  1:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  1:39 AKASHI Takahiro [this message]
2020-02-14 19:16 ` sandbox: CONFIG_SYS_RELOC_GD_ENV_ADDR? Simon Glass
2020-02-14 19:43   ` Tom Rini
2020-02-17  6:01   ` AKASHI Takahiro
2020-02-27 23:40     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214013935.GA22953@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox