* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
@ 2020-02-17 15:30 Andy Shevchenko
2020-02-18 0:24 ` Bin Meng
2020-02-18 0:45 ` Masahiro Yamada
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-02-17 15:30 UTC (permalink / raw)
To: u-boot
This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
As real hardware testing (*) shows the above mentioned commit
breaks U-Boot on it. Revert for the upcoming release. We may get
more information in the future and optimize the code accordingly.
(*) om Intel Edison board.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/cpu/start.S | 2 +-
arch/x86/cpu/start16.S | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
index 26cf995db2..01524635e9 100644
--- a/arch/x86/cpu/start.S
+++ b/arch/x86/cpu/start.S
@@ -50,7 +50,7 @@ _x86boot_start:
movl %cr0, %eax
orl $(X86_CR0_NW | X86_CR0_CD), %eax
movl %eax, %cr0
- invd
+ wbinvd
/*
* Zero the BIST (Built-In Self Test) value since we don't have it.
diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S
index 292e750508..54f4ff6662 100644
--- a/arch/x86/cpu/start16.S
+++ b/arch/x86/cpu/start16.S
@@ -28,7 +28,7 @@ start16:
movl %cr0, %eax
orl $(X86_CR0_NW | X86_CR0_CD), %eax
movl %eax, %cr0
- invd
+ wbinvd
/* load the temporary Global Descriptor Table */
data32 cs lidt idt_ptr
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
2020-02-17 15:30 [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code" Andy Shevchenko
@ 2020-02-18 0:24 ` Bin Meng
2020-02-18 9:37 ` Andy Shevchenko
2020-02-18 0:45 ` Masahiro Yamada
1 sibling, 1 reply; 6+ messages in thread
From: Bin Meng @ 2020-02-18 0:24 UTC (permalink / raw)
To: u-boot
On Mon, Feb 17, 2020 at 11:30 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
>
> As real hardware testing (*) shows the above mentioned commit
> breaks U-Boot on it. Revert for the upcoming release. We may get
> more information in the future and optimize the code accordingly.
>
> (*) om Intel Edison board.
on?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/cpu/start.S | 2 +-
> arch/x86/cpu/start16.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
2020-02-18 0:24 ` Bin Meng
@ 2020-02-18 9:37 ` Andy Shevchenko
2020-02-20 13:43 ` Bin Meng
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2020-02-18 9:37 UTC (permalink / raw)
To: u-boot
On Tue, Feb 18, 2020 at 08:24:03AM +0800, Bin Meng wrote:
> On Mon, Feb 17, 2020 at 11:30 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
> >
> > As real hardware testing (*) shows the above mentioned commit
> > breaks U-Boot on it. Revert for the upcoming release. We may get
> > more information in the future and optimize the code accordingly.
> >
> > (*) om Intel Edison board.
>
> on?
Right. Should I resend or you can fix when apply?
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > arch/x86/cpu/start.S | 2 +-
> > arch/x86/cpu/start16.S | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Bin Meng <bmeng.cn@gmail.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
2020-02-18 9:37 ` Andy Shevchenko
@ 2020-02-20 13:43 ` Bin Meng
0 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2020-02-20 13:43 UTC (permalink / raw)
To: u-boot
On Tue, Feb 18, 2020 at 5:37 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Feb 18, 2020 at 08:24:03AM +0800, Bin Meng wrote:
> > On Mon, Feb 17, 2020 at 11:30 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
> > >
> > > As real hardware testing (*) shows the above mentioned commit
> > > breaks U-Boot on it. Revert for the upcoming release. We may get
> > > more information in the future and optimize the code accordingly.
> > >
> > > (*) om Intel Edison board.
> >
> > on?
>
> Right. Should I resend or you can fix when apply?
No, I fixed it when applying,
>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > arch/x86/cpu/start.S | 2 +-
> > > arch/x86/cpu/start16.S | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> >
> > Acked-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
2020-02-17 15:30 [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code" Andy Shevchenko
2020-02-18 0:24 ` Bin Meng
@ 2020-02-18 0:45 ` Masahiro Yamada
2020-02-18 9:36 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-02-18 0:45 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Tue, Feb 18, 2020 at 12:30 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
>
> As real hardware testing (*) shows the above mentioned commit
> breaks U-Boot on it. Revert for the upcoming release. We may get
> more information in the future and optimize the code accordingly.
>
> (*) om Intel Edison board.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/cpu/start.S | 2 +-
> arch/x86/cpu/start16.S | 2 +-
Reverting arch/x86/cpu/start.S is enough, isn't it?
arch/x86/cpu/start16.S is not compiled for the
Edison board.
start16.S is the start of the Real Mode,
and we are sure no program was running before
U-Boot.
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
> index 26cf995db2..01524635e9 100644
> --- a/arch/x86/cpu/start.S
> +++ b/arch/x86/cpu/start.S
> @@ -50,7 +50,7 @@ _x86boot_start:
> movl %cr0, %eax
> orl $(X86_CR0_NW | X86_CR0_CD), %eax
> movl %eax, %cr0
> - invd
> + wbinvd
>
> /*
> * Zero the BIST (Built-In Self Test) value since we don't have it.
> diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S
> index 292e750508..54f4ff6662 100644
> --- a/arch/x86/cpu/start16.S
> +++ b/arch/x86/cpu/start16.S
> @@ -28,7 +28,7 @@ start16:
> movl %cr0, %eax
> orl $(X86_CR0_NW | X86_CR0_CD), %eax
> movl %eax, %cr0
> - invd
> + wbinvd
>
> /* load the temporary Global Descriptor Table */
> data32 cs lidt idt_ptr
> --
> 2.25.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"
2020-02-18 0:45 ` Masahiro Yamada
@ 2020-02-18 9:36 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-02-18 9:36 UTC (permalink / raw)
To: u-boot
On Tue, Feb 18, 2020 at 09:45:34AM +0900, Masahiro Yamada wrote:
> On Tue, Feb 18, 2020 at 12:30 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12.
> >
> > As real hardware testing (*) shows the above mentioned commit
> > breaks U-Boot on it. Revert for the upcoming release. We may get
> > more information in the future and optimize the code accordingly.
> >
> > (*) om Intel Edison board.
> Reverting arch/x86/cpu/start.S is enough, isn't it?
Had you tested on real hardware?
Since Qemu ~= "no test" for the available hardware, I can't answer to this.
> arch/x86/cpu/start16.S is not compiled for the
> Edison board.
>
> start16.S is the start of the Real Mode,
> and we are sure no program was running before
> U-Boot.
To be on the safer side I prefer to revert completely. Then you may come up
with a new patch with better commit message and testing. To me it sounds fair.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-20 13:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-17 15:30 [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code" Andy Shevchenko
2020-02-18 0:24 ` Bin Meng
2020-02-18 9:37 ` Andy Shevchenko
2020-02-20 13:43 ` Bin Meng
2020-02-18 0:45 ` Masahiro Yamada
2020-02-18 9:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox