From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] fixdep: fix U-Boot own code to handle only valid symbol characters
Date: Tue, 18 Feb 2020 07:06:36 -0500 [thread overview]
Message-ID: <20200218120636.GN18302@bill-the-cat> (raw)
In-Reply-To: <CAK7LNAQZHYPQTQnesV6CLXc_j8f_e836A2nLRmJnuDJ+4iEp=A@mail.gmail.com>
On Tue, Feb 18, 2020 at 08:35:06PM +0900, Masahiro Yamada wrote:
> On Tue, Feb 18, 2020 at 8:06 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Currently, fixdep skips parsing include/linux/kconfig.h, but if it
> > parsed it, it would translate the following code in kconfig.h
> >
> > config_enabled(CONFIG_VAL(option##_MODULE)
> >
> > into:
> >
> > $(wildcard include/config/option##/module.h)
> >
> > When Kbuild includes .*.cmd, it would emit the following error:
> >
> > *** unterminated call to function 'wildcard': missing ')'. Stop.
> >
> > This issue prevents us from importing the upstream Linux commit
> > 638e69cf2230 ("fixdep: do not ignore kconfig.h").
> >
> > Fix this by handling only alphanumerical characters and underscores.
> > This makes sense because they match to the valid character sets in
> > Kconfig symbols.
> >
> > As a side-note, you can reproduce this issue only on GNU Make <= 4.2.1
> >
> > For GNU Make <= 4.2.1, the '#' always means the start of a comment.
> > Hence, GNU Make thinks the closing ')' is missing.
> >
> > The following commit in GNU Make changed how it handles '#' in
> > function invocations. So, this does not happen for GNU Make 4.3
> >
> > | commit c6966b323811c37acedff05b576b907b06aea5f4
> > | Author: Paul Smith <psmith@gnu.org>
> > | Date: Thu Dec 22 18:47:26 2016 -0500
> > |
> > | [SV 20513] Un-escaped # are not comments in function invocations
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
>
>
> Maybe, this can have this tag.
>
> Fixes: 8be60f06c258 ("linux/kconfig.h: add CPP macros useful for
> per-image config options")
Ah, OK, thanks. Yes, I'll go this route to keep bisectability and fully
re-sync the program.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200218/8aae374a/attachment.sig>
next prev parent reply other threads:[~2020-02-18 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 11:05 [PATCH] fixdep: fix U-Boot own code to handle only valid symbol characters Masahiro Yamada
2020-02-18 11:35 ` Masahiro Yamada
2020-02-18 12:06 ` Tom Rini [this message]
2020-02-18 17:40 ` Masahiro Yamada
2020-03-17 15:28 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218120636.GN18302@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox