[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Jaehoon Chung]

CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
broken-cd is already provide to dt-property.
If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.

When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
it also used the value of dt as broken-cd.

Jaehoon Chung (3):
  mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
  mmc: check the flags of host_caps about broken-cd
  mmc: Kconfig: remove MMC_BROKEN_CD configuration

 configs/brppt2_defconfig    |  1 -
 configs/ci20_mmc_defconfig  |  1 -
 configs/meerkat96_defconfig |  1 -
 drivers/mmc/Kconfig         |  5 -----
 drivers/mmc/jz_mmc.c        |  6 ++++--
 drivers/mmc/mmc.c           | 10 +++++-----
 6 files changed, 9 insertions(+), 15 deletions(-)

-- 
2.25.0

[PATCH 1/3] mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default

[Jaehoon Chung]

Add MMC_CAP_NEEDS_POLL by default.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/jz_mmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/jz_mmc.c b/drivers/mmc/jz_mmc.c
index 8d4f886cb4..df995bda2f 100644
--- a/drivers/mmc/jz_mmc.c
+++ b/drivers/mmc/jz_mmc.c
@@ -395,7 +395,8 @@ static struct jz_mmc_plat jz_mmc_plat_static = {
 		.voltages = MMC_VDD_27_28 | MMC_VDD_28_29 | MMC_VDD_29_30 |
 			    MMC_VDD_30_31 | MMC_VDD_31_32 | MMC_VDD_32_33 |
 			    MMC_VDD_33_34 | MMC_VDD_34_35 | MMC_VDD_35_36,
-		.host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS,
+		.host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS |
+			MMC_CAP_NEEDS_POLL,
 
 		.f_min = 375000,
 		.f_max = 48000000,
@@ -452,7 +453,8 @@ static int jz_mmc_ofdata_to_platdata(struct udevice *dev)
 	cfg = &plat->cfg;
 
 	cfg->name = "MSC";
-	cfg->host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS;
+	cfg->host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS |
+		MMC_CAP_NEEDS_POLL;
 
 	ret = mmc_of_parse(dev, cfg);
 	if (ret < 0) {
-- 
2.25.0

[PATCH 2/3] mmc: check the flags of host_caps about broken-cd

[Jaehoon Chung]

broken-cd is provided to dt-property.
Then it's set to MMC_CAP_NEEDS_POLL flag.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/mmc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index b50fcbf6cf..cac60ea034 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -2846,11 +2846,11 @@ int mmc_start_init(struct mmc *mmc)
 	mmc->host_caps = mmc->cfg->host_caps | MMC_CAP(SD_LEGACY) |
 			 MMC_CAP(MMC_LEGACY) | MMC_MODE_1BIT;
 
-#if !defined(CONFIG_MMC_BROKEN_CD)
-	no_card = mmc_getcd(mmc) == 0;
-#else
-	no_card = 0;
-#endif
+	if (mmc->host_caps & MMC_CAP_NEEDS_POLL)
+		no_card = 0;
+	else
+		no_card = mmc_getcd(mmc) == 0;
+
 #if !CONFIG_IS_ENABLED(DM_MMC)
 	/* we pretend there's no card when init is NULL */
 	no_card = no_card || (mmc->cfg->ops->init == NULL);
-- 
2.25.0

[PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration

[Jaehoon Chung]

Remove MMC_BROKEN_CD configuration.
It doesn't need to use configuration, instead use broken-cd property.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 configs/brppt2_defconfig    | 1 -
 configs/ci20_mmc_defconfig  | 1 -
 configs/meerkat96_defconfig | 1 -
 drivers/mmc/Kconfig         | 5 -----
 4 files changed, 8 deletions(-)

diff --git a/configs/brppt2_defconfig b/configs/brppt2_defconfig
index f94ea28376..5d1dfde36e 100644
--- a/configs/brppt2_defconfig
+++ b/configs/brppt2_defconfig
@@ -68,7 +68,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y
 # CONFIG_SPL_BLK is not set
 CONFIG_BOOTCOUNT_LIMIT=y
 CONFIG_SYS_I2C_MXC=y
-CONFIG_MMC_BROKEN_CD=y
 # CONFIG_SPL_DM_MMC is not set
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
diff --git a/configs/ci20_mmc_defconfig b/configs/ci20_mmc_defconfig
index a0b0772f40..f31a3c44f4 100644
--- a/configs/ci20_mmc_defconfig
+++ b/configs/ci20_mmc_defconfig
@@ -34,7 +34,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
 CONFIG_JZ4780_EFUSE=y
 CONFIG_MMC=y
-CONFIG_MMC_BROKEN_CD=y
 CONFIG_DM_MMC=y
 # CONFIG_MMC_HW_PARTITIONING is not set
 CONFIG_MMC_IO_VOLTAGE=y
diff --git a/configs/meerkat96_defconfig b/configs/meerkat96_defconfig
index 45f12115ba..d358ed23a5 100644
--- a/configs/meerkat96_defconfig
+++ b/configs/meerkat96_defconfig
@@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="imx7d-meerkat96"
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_NET_RANDOM_ETHADDR=y
-CONFIG_MMC_BROKEN_CD=y
 CONFIG_DM_MMC=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index 2f0eedc22f..3722e7bc13 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -18,11 +18,6 @@ config MMC_WRITE
 	help
 	  Enable write access to MMC and SD Cards
 
-config MMC_BROKEN_CD
-	bool "Poll for broken card detection case"
-	help
-	  If card  detection feature is broken, just poll to detect.
-
 config DM_MMC
 	bool "Enable MMC controllers using Driver Model"
 	depends on DM
-- 
2.25.0

[PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration

[Peng Fan]

Hi Jaehoon,

> Subject: [PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration
> 
> Remove MMC_BROKEN_CD configuration.
> It doesn't need to use configuration, instead use broken-cd property.

Will this cause issue if board not use dts saying in SPL stage?

Regards,
Peng.

> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  configs/brppt2_defconfig    | 1 -
>  configs/ci20_mmc_defconfig  | 1 -
>  configs/meerkat96_defconfig | 1 -
>  drivers/mmc/Kconfig         | 5 -----
>  4 files changed, 8 deletions(-)
> 
> diff --git a/configs/brppt2_defconfig b/configs/brppt2_defconfig index
> f94ea28376..5d1dfde36e 100644
> --- a/configs/brppt2_defconfig
> +++ b/configs/brppt2_defconfig
> @@ -68,7 +68,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y  # CONFIG_SPL_BLK is
> not set  CONFIG_BOOTCOUNT_LIMIT=y  CONFIG_SYS_I2C_MXC=y
> -CONFIG_MMC_BROKEN_CD=y  # CONFIG_SPL_DM_MMC is not set
> CONFIG_FSL_ESDHC=y  CONFIG_MTD=y diff --git
> a/configs/ci20_mmc_defconfig b/configs/ci20_mmc_defconfig index
> a0b0772f40..f31a3c44f4 100644
> --- a/configs/ci20_mmc_defconfig
> +++ b/configs/ci20_mmc_defconfig
> @@ -34,7 +34,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y  #
> CONFIG_DM_DEVICE_REMOVE is not set  CONFIG_JZ4780_EFUSE=y
> CONFIG_MMC=y -CONFIG_MMC_BROKEN_CD=y  CONFIG_DM_MMC=y  #
> CONFIG_MMC_HW_PARTITIONING is not set
> CONFIG_MMC_IO_VOLTAGE=y diff --git a/configs/meerkat96_defconfig
> b/configs/meerkat96_defconfig index 45f12115ba..d358ed23a5 100644
> --- a/configs/meerkat96_defconfig
> +++ b/configs/meerkat96_defconfig
> @@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y
>  CONFIG_DEFAULT_DEVICE_TREE="imx7d-meerkat96"
>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_NET_RANDOM_ETHADDR=y
> -CONFIG_MMC_BROKEN_CD=y
>  CONFIG_DM_MMC=y
>  CONFIG_FSL_ESDHC=y
>  CONFIG_MTD=y
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
> 2f0eedc22f..3722e7bc13 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -18,11 +18,6 @@ config MMC_WRITE
>  	help
>  	  Enable write access to MMC and SD Cards
> 
> -config MMC_BROKEN_CD
> -	bool "Poll for broken card detection case"
> -	help
> -	  If card  detection feature is broken, just poll to detect.
> -
>  config DM_MMC
>  	bool "Enable MMC controllers using Driver Model"
>  	depends on DM
> --
> 2.25.0

[PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration

[Jaehoon Chung]

On 3/9/20 9:09 AM, Peng Fan wrote:
> Hi Jaehoon,
> 
>> Subject: [PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration
>>
>> Remove MMC_BROKEN_CD configuration.
>> It doesn't need to use configuration, instead use broken-cd property.
> 
> Will this cause issue if board not use dts saying in SPL stage?

I didn't test on board, but if it will be set to MMC_CAPS_NEEDS_POLL, it will be working fine.
In ci200, i had added MMC_CAP_NEEDS_POLL by default. (So it will be working..)
But in fsl_esdhc's case, i didn't touch.. So i need to check it more.

Will resend patch this after considering SPL.

Best Regards,
Jaehoon Chung

> 
> Regards,
> Peng.
> 
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>>  configs/brppt2_defconfig    | 1 -
>>  configs/ci20_mmc_defconfig  | 1 -
>>  configs/meerkat96_defconfig | 1 -
>>  drivers/mmc/Kconfig         | 5 -----
>>  4 files changed, 8 deletions(-)
>>
>> diff --git a/configs/brppt2_defconfig b/configs/brppt2_defconfig index
>> f94ea28376..5d1dfde36e 100644
>> --- a/configs/brppt2_defconfig
>> +++ b/configs/brppt2_defconfig
>> @@ -68,7 +68,6 @@ CONFIG_SPL_DM_SEQ_ALIAS=y  # CONFIG_SPL_BLK is
>> not set  CONFIG_BOOTCOUNT_LIMIT=y  CONFIG_SYS_I2C_MXC=y
>> -CONFIG_MMC_BROKEN_CD=y  # CONFIG_SPL_DM_MMC is not set
>> CONFIG_FSL_ESDHC=y  CONFIG_MTD=y diff --git
>> a/configs/ci20_mmc_defconfig b/configs/ci20_mmc_defconfig index
>> a0b0772f40..f31a3c44f4 100644
>> --- a/configs/ci20_mmc_defconfig
>> +++ b/configs/ci20_mmc_defconfig
>> @@ -34,7 +34,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y  #
>> CONFIG_DM_DEVICE_REMOVE is not set  CONFIG_JZ4780_EFUSE=y
>> CONFIG_MMC=y -CONFIG_MMC_BROKEN_CD=y  CONFIG_DM_MMC=y  #
>> CONFIG_MMC_HW_PARTITIONING is not set
>> CONFIG_MMC_IO_VOLTAGE=y diff --git a/configs/meerkat96_defconfig
>> b/configs/meerkat96_defconfig index 45f12115ba..d358ed23a5 100644
>> --- a/configs/meerkat96_defconfig
>> +++ b/configs/meerkat96_defconfig
>> @@ -34,7 +34,6 @@ CONFIG_OF_CONTROL=y
>>  CONFIG_DEFAULT_DEVICE_TREE="imx7d-meerkat96"
>>  CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>  CONFIG_NET_RANDOM_ETHADDR=y
>> -CONFIG_MMC_BROKEN_CD=y
>>  CONFIG_DM_MMC=y
>>  CONFIG_FSL_ESDHC=y
>>  CONFIG_MTD=y
>> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index
>> 2f0eedc22f..3722e7bc13 100644
>> --- a/drivers/mmc/Kconfig
>> +++ b/drivers/mmc/Kconfig
>> @@ -18,11 +18,6 @@ config MMC_WRITE
>>  	help
>>  	  Enable write access to MMC and SD Cards
>>
>> -config MMC_BROKEN_CD
>> -	bool "Poll for broken card detection case"
>> -	help
>> -	  If card  detection feature is broken, just poll to detect.
>> -
>>  config DM_MMC
>>  	bool "Enable MMC controllers using Driver Model"
>>  	depends on DM
>> --
>> 2.25.0
> 

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Tom Rini]

On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:

> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
> broken-cd is already provide to dt-property.
> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
> 
> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
> it also used the value of dt as broken-cd.
> 
> Jaehoon Chung (3):
>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
>   mmc: check the flags of host_caps about broken-cd
>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
> 
>  configs/brppt2_defconfig    |  1 -
>  configs/ci20_mmc_defconfig  |  1 -
>  configs/meerkat96_defconfig |  1 -
>  drivers/mmc/Kconfig         |  5 -----
>  drivers/mmc/jz_mmc.c        |  6 ++++--
>  drivers/mmc/mmc.c           | 10 +++++-----
>  6 files changed, 9 insertions(+), 15 deletions(-)

Did you size-test this change?  ci20 is extremely tight on space.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200220/3d320af2/attachment.sig>

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Jaehoon Chung]

Hi Tom,

On 2/21/20 4:57 AM, Tom Rini wrote:
> On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
> 
>> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
>> broken-cd is already provide to dt-property.
>> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
>>
>> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
>> it also used the value of dt as broken-cd.
>>
>> Jaehoon Chung (3):
>>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
>>   mmc: check the flags of host_caps about broken-cd
>>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
>>
>>  configs/brppt2_defconfig    |  1 -
>>  configs/ci20_mmc_defconfig  |  1 -
>>  configs/meerkat96_defconfig |  1 -
>>  drivers/mmc/Kconfig         |  5 -----
>>  drivers/mmc/jz_mmc.c        |  6 ++++--
>>  drivers/mmc/mmc.c           | 10 +++++-----
>>  6 files changed, 9 insertions(+), 15 deletions(-)
> 
> Did you size-test this change?  ci20 is extremely tight on space.

I didn't check size-test about this. Is there any check-tool?
If there is check-tool, let me know, plz. Then i will check it. (In future, I will check before sending patch.)
I just checked this patch with CI.

Best Regards,
Jaehoon Chung

> 

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Jaehoon Chung]

On 2/21/20 10:07 AM, Jaehoon Chung wrote:
> Hi Tom,
> 
> On 2/21/20 4:57 AM, Tom Rini wrote:
>> On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
>>
>>> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
>>> broken-cd is already provide to dt-property.
>>> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
>>>
>>> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
>>> it also used the value of dt as broken-cd.
>>>
>>> Jaehoon Chung (3):
>>>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
>>>   mmc: check the flags of host_caps about broken-cd
>>>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
>>>
>>>  configs/brppt2_defconfig    |  1 -
>>>  configs/ci20_mmc_defconfig  |  1 -
>>>  configs/meerkat96_defconfig |  1 -
>>>  drivers/mmc/Kconfig         |  5 -----
>>>  drivers/mmc/jz_mmc.c        |  6 ++++--
>>>  drivers/mmc/mmc.c           | 10 +++++-----
>>>  6 files changed, 9 insertions(+), 15 deletions(-)
>>
>> Did you size-test this change?  ci20 is extremely tight on space.
> 
> I didn't check size-test about this. Is there any check-tool?
> If there is check-tool, let me know, plz. Then i will check it. (In future, I will check before sending patch.)
> I just checked this patch with CI.

u-boot.img  : 327573 -> 327625
u-boot-spl.bin : 10336 -> 10464

What is ci20's limitation size?

Best Regards,
Jaehoon Chung

> 
> Best Regards,
> Jaehoon Chung
> 
>>
> 
> 
> 

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Tom Rini]

On Fri, Feb 21, 2020 at 04:21:52PM +0900, Jaehoon Chung wrote:
> On 2/21/20 10:07 AM, Jaehoon Chung wrote:
> > Hi Tom,
> > 
> > On 2/21/20 4:57 AM, Tom Rini wrote:
> >> On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
> >>
> >>> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
> >>> broken-cd is already provide to dt-property.
> >>> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
> >>>
> >>> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
> >>> it also used the value of dt as broken-cd.
> >>>
> >>> Jaehoon Chung (3):
> >>>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
> >>>   mmc: check the flags of host_caps about broken-cd
> >>>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
> >>>
> >>>  configs/brppt2_defconfig    |  1 -
> >>>  configs/ci20_mmc_defconfig  |  1 -
> >>>  configs/meerkat96_defconfig |  1 -
> >>>  drivers/mmc/Kconfig         |  5 -----
> >>>  drivers/mmc/jz_mmc.c        |  6 ++++--
> >>>  drivers/mmc/mmc.c           | 10 +++++-----
> >>>  6 files changed, 9 insertions(+), 15 deletions(-)
> >>
> >> Did you size-test this change?  ci20 is extremely tight on space.
> > 
> > I didn't check size-test about this. Is there any check-tool?
> > If there is check-tool, let me know, plz. Then i will check it. (In future, I will check before sending patch.)
> > I just checked this patch with CI.
> 
> u-boot.img  : 327573 -> 327625
> u-boot-spl.bin : 10336 -> 10464
> 
> What is ci20's limitation size?


The ci20 limit is  ((14 * 1024) - 0xa00) for SPL.  So we grow by 100
bytes.  And with that small of an SPL we're not using DT, so, is the
driver still acting correctly?  Can we restructure the change such that
growth is absolutely minimal?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200221/a2d112d8/attachment.sig>

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Jaehoon Chung]

On 2/22/20 2:05 AM, Tom Rini wrote:
> On Fri, Feb 21, 2020 at 04:21:52PM +0900, Jaehoon Chung wrote:
>> On 2/21/20 10:07 AM, Jaehoon Chung wrote:
>>> Hi Tom,
>>>
>>> On 2/21/20 4:57 AM, Tom Rini wrote:
>>>> On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
>>>>
>>>>> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
>>>>> broken-cd is already provide to dt-property.
>>>>> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
>>>>>
>>>>> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
>>>>> it also used the value of dt as broken-cd.
>>>>>
>>>>> Jaehoon Chung (3):
>>>>>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
>>>>>   mmc: check the flags of host_caps about broken-cd
>>>>>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
>>>>>
>>>>>  configs/brppt2_defconfig    |  1 -
>>>>>  configs/ci20_mmc_defconfig  |  1 -
>>>>>  configs/meerkat96_defconfig |  1 -
>>>>>  drivers/mmc/Kconfig         |  5 -----
>>>>>  drivers/mmc/jz_mmc.c        |  6 ++++--
>>>>>  drivers/mmc/mmc.c           | 10 +++++-----
>>>>>  6 files changed, 9 insertions(+), 15 deletions(-)
>>>>
>>>> Did you size-test this change?  ci20 is extremely tight on space.
>>>
>>> I didn't check size-test about this. Is there any check-tool?
>>> If there is check-tool, let me know, plz. Then i will check it. (In future, I will check before sending patch.)
>>> I just checked this patch with CI.
>>
>> u-boot.img  : 327573 -> 327625
>> u-boot-spl.bin : 10336 -> 10464
>>
>> What is ci20's limitation size?
> 
> 
> The ci20 limit is  ((14 * 1024) - 0xa00) for SPL.  So we grow by 100
> bytes.  And with that small of an SPL we're not using DT, so, is the
> driver still acting correctly?  Can we restructure the change such that
> growth is absolutely minimal?  Thanks!

I will re-check this side.  I didn't know that ci20 limit is too smaller.
As you mentioned, ci20 SPL  doesn't use dt. So it needs to set to NEEDS_POLL capability.
After checking more, i will resend patches.
Thanks for reviewing. 

Best Regards,
Jaehoon Chung

> 

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Tom Rini]

On Fri, Feb 21, 2020 at 10:07:47AM +0900, Jaehoon Chung wrote:
> Hi Tom,
> 
> On 2/21/20 4:57 AM, Tom Rini wrote:
> > On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
> > 
> >> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
> >> broken-cd is already provide to dt-property.
> >> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
> >>
> >> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
> >> it also used the value of dt as broken-cd.
> >>
> >> Jaehoon Chung (3):
> >>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
> >>   mmc: check the flags of host_caps about broken-cd
> >>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
> >>
> >>  configs/brppt2_defconfig    |  1 -
> >>  configs/ci20_mmc_defconfig  |  1 -
> >>  configs/meerkat96_defconfig |  1 -
> >>  drivers/mmc/Kconfig         |  5 -----
> >>  drivers/mmc/jz_mmc.c        |  6 ++++--
> >>  drivers/mmc/mmc.c           | 10 +++++-----
> >>  6 files changed, 9 insertions(+), 15 deletions(-)
> > 
> > Did you size-test this change?  ci20 is extremely tight on space.
> 
> I didn't check size-test about this. Is there any check-tool?

Yes, buildman has a few different size related options.  I use a wrapper
like this:

#!/bin/bash

# Initial and constant buildman args
ARGS="-devl"
ALL=0
KEEP=0

# Find our arguments
while test $# -ne 0; do
	if [ "$1" == "--all" ]; then
		ALL=1
		shift 1
	elif [ "$1" == "--branch" ]; then
		BRANCH=$2
		shift 2
	elif [ "$1" == "--keep" ]; then
		KEEP=1
		ARGS="$ARGS -k"
		shift 1
	else
		MACHINE=$1
		shift
	fi
done

if [ -z $MACHINE ]; then
	echo Usage: $0 MACHINE [--all] [--keep] [--branch BRANCH]
	exit 1
fi

# If not all, then only first/last
if [ $ALL -ne 1 ]; then
	ARGS="$ARGS --step 0"
fi

if [ ! -z $BRANCH ]; then
	ARGS="$ARGS -b $BRANCH"
else
	ARGS="$ARGS -b `git rev-parse --abbrev-ref HEAD`"
fi

mkdir -p /tmp/$MACHINE

export SOURCE_DATE_EPOCH=`date +%s`
./tools/buildman/buildman -o /tmp/$MACHINE $ARGS -SBC $MACHINE
./tools/buildman/buildman -o /tmp/$MACHINE $ARGS -SsB $MACHINE

[ $KEEP -eq 0 ] && rm -rf /tmp/$MACHINE

This will either build the first/last commit in a series (do things
change at all?) or every commit (What commit introduced the growth I
want to know more about).  I can also tell it to keep the resulting
output directory if I want to dig around the map files more by hand.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200221/eb541583/attachment.sig>

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

[Jaehoon Chung]

On 2/21/20 10:38 PM, Tom Rini wrote:
> On Fri, Feb 21, 2020 at 10:07:47AM +0900, Jaehoon Chung wrote:
>> Hi Tom,
>>
>> On 2/21/20 4:57 AM, Tom Rini wrote:
>>> On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote:
>>>
>>>> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig.
>>>> broken-cd is already provide to dt-property.
>>>> If want to poll card-detect, set to broken-cd instead of enabling CONFIG_MMC_BROKEN_CD.
>>>>
>>>> When checked the boards that is eabled CONFIG_MMC_BROKEN_CD,
>>>> it also used the value of dt as broken-cd.
>>>>
>>>> Jaehoon Chung (3):
>>>>   mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default
>>>>   mmc: check the flags of host_caps about broken-cd
>>>>   mmc: Kconfig: remove MMC_BROKEN_CD configuration
>>>>
>>>>  configs/brppt2_defconfig    |  1 -
>>>>  configs/ci20_mmc_defconfig  |  1 -
>>>>  configs/meerkat96_defconfig |  1 -
>>>>  drivers/mmc/Kconfig         |  5 -----
>>>>  drivers/mmc/jz_mmc.c        |  6 ++++--
>>>>  drivers/mmc/mmc.c           | 10 +++++-----
>>>>  6 files changed, 9 insertions(+), 15 deletions(-)
>>>
>>> Did you size-test this change?  ci20 is extremely tight on space.
>>
>> I didn't check size-test about this. Is there any check-tool?
> 
> Yes, buildman has a few different size related options.  I use a wrapper
> like this:
> 
> #!/bin/bash
> 
> # Initial and constant buildman args
> ARGS="-devl"
> ALL=0
> KEEP=0
> 
> # Find our arguments
> while test $# -ne 0; do
> 	if [ "$1" == "--all" ]; then
> 		ALL=1
> 		shift 1
> 	elif [ "$1" == "--branch" ]; then
> 		BRANCH=$2
> 		shift 2
> 	elif [ "$1" == "--keep" ]; then
> 		KEEP=1
> 		ARGS="$ARGS -k"
> 		shift 1
> 	else
> 		MACHINE=$1
> 		shift
> 	fi
> done
> 
> if [ -z $MACHINE ]; then
> 	echo Usage: $0 MACHINE [--all] [--keep] [--branch BRANCH]
> 	exit 1
> fi
> 
> # If not all, then only first/last
> if [ $ALL -ne 1 ]; then
> 	ARGS="$ARGS --step 0"
> fi
> 
> if [ ! -z $BRANCH ]; then
> 	ARGS="$ARGS -b $BRANCH"
> else
> 	ARGS="$ARGS -b `git rev-parse --abbrev-ref HEAD`"
> fi
> 
> mkdir -p /tmp/$MACHINE
> 
> export SOURCE_DATE_EPOCH=`date +%s`
> ./tools/buildman/buildman -o /tmp/$MACHINE $ARGS -SBC $MACHINE
> ./tools/buildman/buildman -o /tmp/$MACHINE $ARGS -SsB $MACHINE
> 
> [ $KEEP -eq 0 ] && rm -rf /tmp/$MACHINE
> 
> This will either build the first/last commit in a series (do things
> change at all?) or every commit (What commit introduced the growth I
> want to know more about).  I can also tell it to keep the resulting
> output directory if I want to dig around the map files more by hand.

Thanks for sharing! I also checked patch with buildman. This information is helpful to me.

Best Regards,
Jaehoon Chung

>