From: Moses Christopher <moseschristopherb@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] tiny-printf: revert patch to fix spl eth boot
Date: Tue, 25 Feb 2020 18:15:28 +0000 [thread overview]
Message-ID: <20200225181528.2457-1-moseschristopherb@gmail.com> (raw)
From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
- Revert commit 831c16111959 ("tiny-printf: Reorder code to support %p")
The mentioned commit does not handle the ethaddr properly.
Hence, I tried to disable SPL_TINY_PRINTF, but then it was suggested
to keep using the tiny-printf library in SPL and revert the patch
that caused the issue.
- The issue is observed in both Beaglebone Black and Guardian Board,
while trying to boot the board using USB-ETH in SPL stage.
Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
---
lib/tiny-printf.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
index 1138c7012a..8ee0ffb9ca 100644
--- a/lib/tiny-printf.c
+++ b/lib/tiny-printf.c
@@ -268,20 +268,10 @@ static int _vprintf(struct printf_info *info, const char *fmt, va_list va)
}
break;
case 'p':
-#ifdef DEBUG
pointer(info, fmt, va_arg(va, void *));
- /*
- * Skip this because it pulls in _ctype which is
- * 256 bytes, and we don't generally implement
- * pointer anyway
- */
while (isalnum(fmt[0]))
fmt++;
break;
-#else
- islong = true;
- /* no break */
-#endif
case 'x':
if (islong) {
num = va_arg(va, unsigned long);
--
2.20.1
reply other threads:[~2020-02-25 18:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225181528.2457-1-moseschristopherb@gmail.com \
--to=moseschristopherb@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox