* [PATCH] tiny-printf: revert patch to fix spl eth boot
@ 2020-02-25 18:15 Moses Christopher
0 siblings, 0 replies; only message in thread
From: Moses Christopher @ 2020-02-25 18:15 UTC (permalink / raw)
To: u-boot
From: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
- Revert commit 831c16111959 ("tiny-printf: Reorder code to support %p")
The mentioned commit does not handle the ethaddr properly.
Hence, I tried to disable SPL_TINY_PRINTF, but then it was suggested
to keep using the tiny-printf library in SPL and revert the patch
that caused the issue.
- The issue is observed in both Beaglebone Black and Guardian Board,
while trying to boot the board using USB-ETH in SPL stage.
Signed-off-by: Moses Christopher Bollavarapu <moseschristopherb@gmail.com>
---
lib/tiny-printf.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
index 1138c7012a..8ee0ffb9ca 100644
--- a/lib/tiny-printf.c
+++ b/lib/tiny-printf.c
@@ -268,20 +268,10 @@ static int _vprintf(struct printf_info *info, const char *fmt, va_list va)
}
break;
case 'p':
-#ifdef DEBUG
pointer(info, fmt, va_arg(va, void *));
- /*
- * Skip this because it pulls in _ctype which is
- * 256 bytes, and we don't generally implement
- * pointer anyway
- */
while (isalnum(fmt[0]))
fmt++;
break;
-#else
- islong = true;
- /* no break */
-#endif
case 'x':
if (islong) {
num = va_arg(va, unsigned long);
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-25 18:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 18:15 [PATCH] tiny-printf: revert patch to fix spl eth boot Moses Christopher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox