From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader.
Date: Mon, 2 Mar 2020 08:01:09 -0500 [thread overview]
Message-ID: <20200302130109.GQ18302@bill-the-cat> (raw)
In-Reply-To: <124bb61f-b980-dc5e-9695-4da5da2f0b37@northern.tech>
On Mon, Mar 02, 2020 at 11:22:27AM +0100, Kristian Amlie wrote:
> On 28/02/2020 16:32, Tom Rini wrote:
> > On Tue, Feb 25, 2020 at 06:22:16PM +0100, Kristian Amlie wrote:
> >
> >> EFI was disabled in f95b8a4b5f64f because of the missing DTB file,
> >> and indeed, the DTB file is required to load recent versions of GRUB
> >> (2.04) correctly.
> >>
> >> Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
> >> ---
> >> configs/vexpress_ca9x4_defconfig | 2 +-
> >> include/configs/vexpress_common.h | 3 ++-
> >> 2 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/configs/vexpress_ca9x4_defconfig b/configs/vexpress_ca9x4_defconfig
> >> index 2119df6b10..6bd1f253b6 100644
> >> --- a/configs/vexpress_ca9x4_defconfig
> >> +++ b/configs/vexpress_ca9x4_defconfig
> >> @@ -34,4 +34,4 @@ CONFIG_SMC911X_32_BIT=y
> >> CONFIG_BAUDRATE=38400
> >> CONFIG_CONS_INDEX=0
> >> CONFIG_OF_LIBFDT=y
> >> -# CONFIG_EFI_LOADER is not set
> >> +CONFIG_DEFAULT_FDT_FILE="vexpress-v2p-ca9.dtb"
> >> diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h
> >> index 7f215a6707..e73658a9e6 100644
> >> --- a/include/configs/vexpress_common.h
> >> +++ b/include/configs/vexpress_common.h
> >> @@ -207,7 +207,8 @@
> >> "devtmpfs.mount=0 vmalloc=256M\0" \
> >> "bootflash=run flashargs; " \
> >> "cp ${ramdisk_addr} ${ramdisk_addr_r} ${maxramdisk}; " \
> >> - "bootm ${kernel_addr} ${ramdisk_addr_r}\0"
> >> + "bootm ${kernel_addr} ${ramdisk_addr_r}\0" \
> >> + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0"
> >>
> >> /* FLASH and environment organization */
> >> #define PHYS_FLASH_SIZE 0x04000000 /* 64MB */
> >
> > Did you test build all of the vexpress platforms? There's a common file
> > for the 5 different ones. Thanks!
>
> The two boards vexpress_aemv8a_juno_defconfig and
> vexpress_aemv8a_semi_defconfig don't compile at all, even without the
> patch. The other three compile just fine both with and without the patch.
Don't compile where / how? All 5 compile with their defconfigs today.
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200302/ca1e1930/attachment.sig>
next prev parent reply other threads:[~2020-03-02 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:22 [PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader Kristian Amlie
2020-02-28 15:32 ` Tom Rini
2020-03-02 10:22 ` Kristian Amlie
2020-03-02 13:01 ` Tom Rini [this message]
2020-03-02 13:15 ` Kristian Amlie
2020-03-20 8:07 ` Kristian Amlie
2020-03-27 1:39 ` Tom Rini
2020-03-27 5:44 ` Heinrich Schuchardt
2020-03-27 7:18 ` Kristian Amlie
2020-03-27 15:45 ` Tom Rini
2020-03-28 9:36 ` Heinrich Schuchardt
2020-03-28 10:12 ` Heinrich Schuchardt
2020-03-30 9:20 ` Kristian Amlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302130109.GQ18302@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox