From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "dm: core: device: switch off power domain after device removal"
Date: Mon, 2 Mar 2020 21:07:20 +0100 [thread overview]
Message-ID: <20200302210720.64bdca31@crub> (raw)
In-Reply-To: <4ca30460-15e5-1d9e-9a52-0044e308a590@baylibre.com>
Hi Neil,
On Mon, 2 Mar 2020 10:30:31 +0100
Neil Armstrong narmstrong at baylibre.com wrote:
> Hi Analolij,
>
> On 17/02/2020 12:53, Anatolij Gustschin wrote:
> > On Mon, 17 Feb 2020 10:10:36 +0100
> > Neil Armstrong narmstrong at baylibre.com wrote:
> >
> >> This commit breaks Linux boot on Amlogic libretech-cc, libretech-ac, sei510,
> >> sei610 board by automatically disabling the power domain after device removal.
> >> This because the power domain associated to the video driver must be kept
> >> enabled for linux to boot.
> >>
> >> The only way is to use the introduced flag DM_FLAG_DEFAULT_PD_CTRL_OFF, which
> >> removes automatic handling of power domain.
> >> This flag is not a complete solution since it will force reverting to manually
> >> enable the power domain from the driver probe.
> >>
> >> Instead a flag to keep the power domain enabled after removal should be
> >> introduced.
> >>
> >> In the meantime revert this commit until a proper solution is found.
> >>
> >> This reverts commit 52edfed65de967a86983a55c51ba0727090efc43.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> Hi Simon, Tom,
> >>
> >> This revert is the simplest fix to make the boards boot again on v2020.04,
> >> the goal is to make this behavior happen again with a proper flag to keep the
> >> power domain enabled on specific drivers.
> >>
> >> I can push it on my next PR on my branch, is it ok ?
> >
> > Please test if these two patches fix the problem:
> > http://patchwork.ozlabs.org/patch/1239143
> > http://patchwork.ozlabs.org/patch/1239144
>
> Should I apply these through my tree or you plan to push these yourself ?
These patches are assigned to Simon in patchwork, and are in his tree
under build-testing I think.
--
Anatolij
prev parent reply other threads:[~2020-03-02 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:10 [PATCH] Revert "dm: core: device: switch off power domain after device removal" Neil Armstrong
2020-02-17 11:53 ` Anatolij Gustschin
2020-02-17 16:04 ` Neil Armstrong
2020-03-02 9:30 ` Neil Armstrong
2020-03-02 20:07 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302210720.64bdca31@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox