public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrick Delaunay <patrick.delaunay@st.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 0/4] Ensure 16 alignment of reserved memory in board_f.c
Date: Tue, 10 Mar 2020 10:15:01 +0100	[thread overview]
Message-ID: <20200310091505.24862-1-patrick.delaunay@st.com> (raw)


Hi,

It is a V4 with only cosmetics udpate (s/insure/ensure)
for the V3 serie:
http://patchwork.ozlabs.org/project/uboot/list/?series=162918&state=*

V2 was:
http://patchwork.ozlabs.org/project/uboot/list/?series=154685&state=*

After the first correction, only for bootstage alignment,
I remove the stm32mp1 workaround in the 2nd patch.

The 4th patch is a complete solution to alignment
(proposed in comment 5 of
 http://patchwork.ozlabs.org/patch/1201452/#2327366)
I always align the reserved memory to 16 bytes with a new function
reserve_stack_aligned().

But this patch causes an issue on ARM 32 bits, as the relocated gd
pointer is not initialized with gd->new_gd as expected now in
reserve_global_data() but is hard-coded with:
  relocated gd = gd->bd - GD_SIZE
  {with GD_SIZE = sizeof(struct global_data)}

After the 4rd patch, this assumption in not more true as
sizeof(struct global_data) is not always 16 bytes aligned.

This issue is solved with the 3rd patch of the serie
  arm: set the relocated gd with gd->new_gd

Only tested on STM32MP157C-EV1 board (ARM32 architecture).


Changes in v4:
- replace insure by ensure in comment
- replace insure by ensure

Changes in v3:
- rename reserve_sp to reserve_stack_aligned

Changes in v2:
- import: [U-Boot,v3] board_f.c: Insure gd->new_bootstage alignment
- fix commit message s/bits/bytes/

Patrice Chotard (1):
  board_f.c: Ensure gd->new_bootstage alignment

Patrick Delaunay (3):
  Revert "stm32mp1: remove the imply BOOTSTAGE"
  arm: set the relocated gd with gd->new_gd
  board_f.c: Ensure 16 alignment of start_addr_sp and reserved memory

 arch/arm/lib/crt0.S           |  3 +--
 arch/arm/mach-stm32mp/Kconfig |  2 ++
 common/board_f.c              | 27 ++++++++++++++++++---------
 3 files changed, 21 insertions(+), 11 deletions(-)

-- 
2.17.1

             reply	other threads:[~2020-03-10  9:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  9:15 Patrick Delaunay [this message]
2020-03-10  9:15 ` [PATCH v4 1/4] board_f.c: Ensure gd->new_bootstage alignment Patrick Delaunay
2020-04-17 21:08   ` Tom Rini
2020-03-10  9:15 ` [PATCH v4 2/4] Revert "stm32mp1: remove the imply BOOTSTAGE" Patrick Delaunay
2020-04-17 21:08   ` Tom Rini
2020-03-10  9:15 ` [PATCH v4 3/4] arm: set the relocated gd with gd->new_gd Patrick Delaunay
2020-04-17 21:08   ` Tom Rini
2020-03-10  9:15 ` [PATCH v4 4/4] board_f.c: Ensure 16 alignment of start_addr_sp and reserved memory Patrick Delaunay
2020-04-17 21:08   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310091505.24862-1-patrick.delaunay@st.com \
    --to=patrick.delaunay@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox