From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2] Makefile: doesn't need check stack size when dtb is not built
Date: Wed, 11 Mar 2020 09:01:17 +0900 [thread overview]
Message-ID: <20200311000116.GJ13880@linaro.org> (raw)
In-Reply-To: <604acbad-ba9a-75a0-d57c-291992ec77e4@wwwdotorg.org>
Tom,
On Tue, Mar 10, 2020 at 09:56:42AM -0600, Stephen Warren wrote:
> On 3/9/20 6:20 PM, AKASHI Takahiro wrote:
> > The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into
> > initial stack") adds an extra check for stack size in BSS if
> > CONFIG_SYS_INIT_SP_BSS_OFFSET is enabled.
> > This check, however, doesn't make sense under the configuration where
> > control dtb won't be built in and it should be void in such cases.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Fixes: 5fed97af20da ("Makefile: ensure DTB doesn't overflow into
> > initial stack")
>
> It would be best if that line wasn't wrapped; that will make it easier for
> anyone searching for the commit description, since they won't have to know
> to search for a substring of the the description instead of the whole thing.
Can you make this change for me when you merge this patch, please?
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
Thanks,
-Takahiro Akashi
next prev parent reply other threads:[~2020-03-11 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 0:20 [PATCH v2] Makefile: doesn't need check stack size when dtb is not built AKASHI Takahiro
2020-03-10 15:56 ` Stephen Warren
2020-03-11 0:01 ` AKASHI Takahiro [this message]
2020-03-13 17:25 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311000116.GJ13880@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox