From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Wed, 11 Mar 2020 09:01:17 +0900 Subject: [PATCH v2] Makefile: doesn't need check stack size when dtb is not built In-Reply-To: <604acbad-ba9a-75a0-d57c-291992ec77e4@wwwdotorg.org> References: <20200310002043.15523-1-takahiro.akashi@linaro.org> <604acbad-ba9a-75a0-d57c-291992ec77e4@wwwdotorg.org> Message-ID: <20200311000116.GJ13880@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Tom, On Tue, Mar 10, 2020 at 09:56:42AM -0600, Stephen Warren wrote: > On 3/9/20 6:20 PM, AKASHI Takahiro wrote: > > The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into > > initial stack") adds an extra check for stack size in BSS if > > CONFIG_SYS_INIT_SP_BSS_OFFSET is enabled. > > This check, however, doesn't make sense under the configuration where > > control dtb won't be built in and it should be void in such cases. > > > > Signed-off-by: AKASHI Takahiro > > Fixes: 5fed97af20da ("Makefile: ensure DTB doesn't overflow into > > initial stack") > > It would be best if that line wasn't wrapped; that will make it easier for > anyone searching for the commit description, since they won't have to know > to search for a substring of the the description instead of the whole thing. Can you make this change for me when you merge this patch, please? > Reviewed-by: Stephen Warren Thanks, -Takahiro Akashi