From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] mkimage: fit_image: Make fit header and data align to 512
Date: Fri, 13 Mar 2020 09:13:12 -0400 [thread overview]
Message-ID: <20200313131312.GD12423@bill-the-cat> (raw)
In-Reply-To: <4c6aad16-a1e7-f874-0ad0-9b4ee2a6092e@prevas.dk>
On Fri, Mar 13, 2020 at 02:09:32PM +0100, Rasmus Villemoes wrote:
> On 13/03/2020 03.07, Heinrich Schuchardt wrote:
> > Am March 13, 2020 1:50:41 AM UTC schrieb Kever Yang <kever.yang@rock-chips.com>:
> >> The image is usually stored in block device like emmc, SD card, make
> >> the
> >> offset of image data aligned to block(512 byte) can avoid data copy
> >> during boot process.
> >> eg. SPL boot from FIT image with external data:
> >> - SPL read the first block of FIT image, and then parse the header;
> >> - SPL read image data separately;
> >> - The first image offset is the base_offset which is the header size;
> >> - The second image offset is just after the first image;
> >> - If the offset of imge does not aligned, SPL will do memcpy;
> >> The header size is a ramdon number, which is very possible not aligned,
> >> so
> >> add align for FIT header and image data for better performance.
>
> Why not let -B take an integer argument, so the same flag can be used
> the day someone needs stuff to be aligned on a 4096 byte boundary?
Agreed, I'm not happy with the 512 byte assumption either. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200313/7568431a/attachment.sig>
next prev parent reply other threads:[~2020-03-13 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 1:50 [PATCH] mkimage: fit_image: Make fit header and data align to 512 Kever Yang
2020-03-13 2:07 ` Heinrich Schuchardt
2020-03-13 13:09 ` Rasmus Villemoes
2020-03-13 13:13 ` Tom Rini [this message]
2020-03-16 3:08 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313131312.GD12423@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox