U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCHv2 8/8] configs: Drop '$(ARCH)' usage in CONFIG_SPL_LDSCRIPT
Date: Sun, 15 Mar 2020 09:06:10 -0400	[thread overview]
Message-ID: <20200315130610.GP12423@bill-the-cat> (raw)
In-Reply-To: <CAK7LNATQB9ACue1ptoOp9hQePcSej0MJddNMUgmwRC8ZwQku1w@mail.gmail.com>

On Sun, Mar 15, 2020 at 08:56:14PM +0900, Masahiro Yamada wrote:
> On Thu, Mar 12, 2020 at 7:12 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > In a few boards we had overridden, intentionally, the value used for
> > CONFIG_SPL_LDSCRIPT.  However, rather than using the ARCH value (arm)
> > they used the $(ARCH) variable in make.  This doesn't help really, so
> > switch to a hard-coded value.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Changes in v2:
> > - New patch
> > ---
> >  configs/axm_defconfig    | 2 +-
> >  configs/brppt2_defconfig | 2 +-
> >  configs/taurus_defconfig | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/configs/axm_defconfig b/configs/axm_defconfig
> > index 57683b183fc2..1ae78463d457 100644
> > --- a/configs/axm_defconfig
> > +++ b/configs/axm_defconfig
> > @@ -5,7 +5,7 @@ CONFIG_SYS_THUMB_BUILD=y
> >  # CONFIG_SPL_USE_ARCH_MEMCPY is not set
> >  # CONFIG_SPL_USE_ARCH_MEMSET is not set
> >  CONFIG_ARCH_AT91=y
> > -CONFIG_SPL_LDSCRIPT="arch/$(ARCH)/cpu/u-boot-spl.lds"
> > +CONFIG_SPL_LDSCRIPT="arch/arm/cpu/u-boot-spl.lds"
> 
> 
> This is the same as the default,
> so I think this can be simply removed.
> (and squashed into "Kconfig: Remove redundant variable sets)").

For these specific defconfigs their default is changed by CPU type to
not be the default ARM one.  So the commit message wasn't clear
enough here so I'll add a few more words to be clear they did not use
the arch default value one evaluated but a different one when pushing.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200315/66847766/attachment.sig>

  reply	other threads:[~2020-03-15 13:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 22:11 [PATCHv2 1/8] spl: Kconfig: Escape '$(ARCH)' in LDSCRIPT entries Tom Rini
2020-03-11 22:11 ` [PATCHv2 2/8] Kconfig: Remove redundant variable sets Tom Rini
     [not found]   ` <752D002CFF5D0F4FA35C0100F1D73F3FA46E35F2@ATCPCS16.andestech.com>
2020-03-12  6:19     ` Rick Chen
2020-03-12 11:31   ` Michal Simek
2020-03-15  2:14   ` Masahiro Yamada
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 3/8] edminiv2: Move CONFIG_SPL_LDSCRIPT to defconfig Tom Rini
2020-03-15 11:11   ` Masahiro Yamada
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 4/8] mach-davinci: Hard-code the default SPL_LDSCRIPT path Tom Rini
2020-03-12  3:41   ` Lokesh Vutla
2020-03-15 11:11   ` Masahiro Yamada
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 5/8] Azure / GitLab / Travis: Add Kconfig unit tests to a job Tom Rini
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 6/8] scripts/dtc: Update to upstream version v1.4.6-21-g84e414b0b5bc Tom Rini
2020-03-13 20:01   ` Rob Herring
2020-03-13 20:10     ` Tom Rini
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 7/8] kconfig / kbuild: re-sync with Linux 4.18 Tom Rini
2020-03-15  2:04   ` Masahiro Yamada
2020-03-17 15:29   ` Tom Rini
2020-03-11 22:11 ` [PATCHv2 8/8] configs: Drop '$(ARCH)' usage in CONFIG_SPL_LDSCRIPT Tom Rini
2020-03-15 11:56   ` Masahiro Yamada
2020-03-15 13:06     ` Tom Rini [this message]
2020-03-17 15:29   ` Tom Rini
2020-03-15  2:05 ` [PATCHv2 1/8] spl: Kconfig: Escape '$(ARCH)' in LDSCRIPT entries Masahiro Yamada
2020-03-17 15:29 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315130610.GP12423@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox