From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 19/23] travis/gitlab/azure: Drop the -E flag
Date: Tue, 17 Mar 2020 12:42:51 -0400 [thread overview]
Message-ID: <20200317164251.GU12423@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ28ADiPoAhXXG-RDqCZR6B8Od2ZN9kq+aQivDcHqsucig@mail.gmail.com>
On Tue, Mar 17, 2020 at 10:32:32AM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Tue, 17 Mar 2020 at 10:22, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Mar 17, 2020 at 10:11:52AM -0600, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Mon, 16 Mar 2020 at 15:21, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Sun, Mar 15, 2020 at 05:42:59PM -0600, Simon Glass wrote:
> > > >
> > > > > It doesn't seem to make sense to tell buildman to report warning as errors
> > > > > (thus ensuring there are no warnings) and then ignore the warnings.
> > > > >
> > > > > The simplist thing is to just drop the -E flag. This allows us to drop the
> > > > > check for exit code 129.
> > > > >
> > > > > Dropping -E is not enough to cover all warnings though. For example this
> > > > > warning:
> > > > >
> > > > > ===================== WARNING ======================
> > > > > This board does not use CONFIG_DM. CONFIG_DM will be
> > > > > compulsory starting with the v2020.01 release.
> > > > > Failure to update may result in board removal.
> > > > > See doc/driver-model/migration.rst for more info.
> > > > >
> > > > > also causes buildman to return an exit code of 129. So use -W to suppress
> > > > > that, since otherwise the build will fail.
> > > > >
> > > > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > > Fixes: 329f5ef51d2 (travis.yml: run buildman with option -E)
> > > >
> > > > Ah, we have something funny going on, or at least not clear enough. We
> > > > need and want -E here as that causes us to build with -Werror and so
> > > > warnings become errors and the build fails. We still ignore warnings
> > > > such as "go convert X to DM" (which is its own issue to deal with) and
> > > > also dtc warnings (which is its own issue to deal with).
> > >
> > > OK I see. So should we add both -E and -W? Perhaps the is the behaviour we want?
> >
> > I'm not sure. We need -E, yes. I guess I'm ambivalent on if we should
> > make buildman have an option to return 0 still here, or just have CI
> > know that specific error-code is OK as we've otherwise turned code
> > warnings to errors.
> >
> > Having typed that, I see the problem I have now. We need to make it
> > clearer, in both the -W and -E cases what kinds of warnings we're
> > talking about. -E enables -Werror to the C compiler. -W suppresses the
> > kinds of WARNINGS we echo to console but I'm not sure how to best
> > characterize.
>
> OK shall I beef up the help text in buildman for those two?
And the commit message for adding -W, yes, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/6cdec314/attachment.sig>
next prev parent reply other threads:[~2020-03-17 16:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 23:42 [PATCH v2 00/23] gitlab: Simplify the test script Simon Glass
2020-03-15 23:42 ` [PATCH v2 01/23] sandbox: Add documentation about required/useful packages Simon Glass
2020-03-15 23:42 ` [PATCH v2 02/23] main: Drop show_boot_progress() prototype Simon Glass
2020-03-15 23:42 ` [PATCH v2 03/23] buildman: Document the members of BuilderJob Simon Glass
2020-03-15 23:42 ` [PATCH v2 04/23] bulidman: Add support for a simple build Simon Glass
2020-03-15 23:42 ` [PATCH v2 05/23] buildman: Update help for -d Simon Glass
2020-03-15 23:42 ` [PATCH v2 06/23] buildman: Allow ignoring warnings in the return code Simon Glass
2020-03-16 20:50 ` Tom Rini
2020-03-17 16:11 ` Simon Glass
2020-03-15 23:42 ` [PATCH v2 07/23] buildman: Be more selective about which directories to remove Simon Glass
2020-03-15 23:42 ` [PATCH v2 08/23] buildman: Allow building within a subdir of the current dir Simon Glass
2020-03-15 23:42 ` [PATCH v2 09/23] buildman: Drop the -a option Simon Glass
2020-03-15 23:42 ` [PATCH v2 10/23] travis: Don't copy files into .bm-work/ Simon Glass
2020-03-16 21:23 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 11/23] travis: Split the building into two parts Simon Glass
2020-03-16 21:23 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 12/23] gitlab/azure: Use the -w option for sandbox_spl Simon Glass
2020-03-16 21:23 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 13/23] travis/gitlab/azure: Use --board buildman flag with test.py Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 14/23] travis/gitlab/azure: Drop BUILDMAN variable " Simon Glass
2020-03-16 21:16 ` Tom Rini
2020-03-17 16:29 ` Simon Glass
2020-03-17 16:42 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 15/23] travis/gitlab/azure: Drop the buildman -d flag Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 16/23] gitlab/azure: Drop unnecessary if..fi when using test.py Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 17/23] gitlab/azure: Use -w flag for all test.py builds Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 18/23] travis/gitlab/azure: Use bash to avoid a_test_which_does_not_exist Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:42 ` [PATCH v2 19/23] travis/gitlab/azure: Drop the -E flag Simon Glass
2020-03-16 21:21 ` Tom Rini
2020-03-17 16:11 ` Simon Glass
2020-03-17 16:22 ` Tom Rini
2020-03-17 16:32 ` Simon Glass
2020-03-17 16:42 ` Tom Rini [this message]
2020-03-15 23:43 ` [PATCH v2 20/23] travis/gitlab/azure: Enable test_handoff Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:43 ` [PATCH v2 21/23] travis/gitlab/azure: Simplify the exit code for test.py Simon Glass
2020-03-15 23:43 ` [PATCH v2 22/23] travis/gitlab/azure: Drop repeated buildman call with test.py Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-15 23:43 ` [PATCH v2 23/23] test/py: Allow using buildman to build U-Boot Simon Glass
2020-03-16 21:24 ` Tom Rini
2020-03-16 22:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317164251.GU12423@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox